chore(CI): Adjust testing matrix for Nextcloud 35 on stable35 - #989
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
📝 WalkthroughWalkthroughThe project now targets Nextcloud stable35. Composer uses the stable35 OCP package and PHP 8.3, and removes the root PHP requirement and security advisory dependency. The application version changes to 35.0.0. PHPUnit runs on updated Ubuntu runners against stable35. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
composer.json (1)
50-50: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winAlign the PHPUnit platform with the CI baseline.
CI runs
composer test:uniton PHP 8.3 and 8.4, butvendor-bin/phpunit/composer.jsonand its lockfile resolve dependencies against PHP 8.2. Set both isolated platform entries to 8.3, or document why PHP 8.2 is intentional.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e63a1ef9-b659-4b43-886f-4ac7f36c7637
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
.github/workflows/phpunit.ymlappinfo/info.xmlcomposer.json
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.
|
I suppose the base branch should be |
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
d9898cf to
11611cf
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
🤖 AI (if applicable)