Skip to content

fix: add response to upload when assembling chunks#2092

Merged
skjnldsv merged 1 commit into
mainfrom
fix/noid/assemble-virus-error
May 12, 2026
Merged

fix: add response to upload when assembling chunks#2092
skjnldsv merged 1 commit into
mainfrom
fix/noid/assemble-virus-error

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

Fix issue:

  • on upload of 'eicar' file to Files app (with AV running), upload is correctly blocked with message 'Virus XX is detected...'. However for large files (e.g. zip archive with 'eicar' file inside) it fails on chunk assembly, but toast message contains (Unknown error during upload)

Copy from where PUT request is handled:

// Attach response to the upload object
if ((error as AxiosError)?.response) {
upload.response = (error as AxiosError).response as AxiosResponse
}

Haven't tested with bundled app. though response body is the same for PUT and MOVE
imageimage

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy requested review from ShGKme and susnux May 12, 2026 10:10
@Antreesy Antreesy self-assigned this May 12, 2026
@Antreesy Antreesy added the bug Something isn't working label May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.30%. Comparing base (398a3cd) to head (2a26b16).

Files with missing lines Patch % Lines
lib/uploader/uploader.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2092      +/-   ##
==========================================
- Coverage   36.39%   36.30%   -0.10%     
==========================================
  Files          17       17              
  Lines         772      774       +2     
  Branches      144      145       +1     
==========================================
  Hits          281      281              
- Misses        478      480       +2     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Antreesy
Copy link
Copy Markdown
Contributor Author

Any hints on Cypress failures? CI outputs errors that don't sound related

@skjnldsv
Copy link
Copy Markdown
Contributor

Any hints on Cypress failures? CI outputs errors that don't sound related

It does not indeed.
Is it failing on master too?

@Antreesy
Copy link
Copy Markdown
Contributor Author

I see every open dependabot PR here fails with 1 or 2 of the same Cypress tests. So seems flaky overall

@skjnldsv
Copy link
Copy Markdown
Contributor

I see every open dependabot PR here fails with 1 or 2 of the same Cypress tests. So seems flaky overall

cries

@skjnldsv skjnldsv merged commit ca42079 into main May 12, 2026
18 of 28 checks passed
@skjnldsv skjnldsv deleted the fix/noid/assemble-virus-error branch May 12, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants