fix: add response to upload when assembling chunks#2092
Merged
Conversation
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
- Coverage 36.39% 36.30% -0.10%
==========================================
Files 17 17
Lines 772 774 +2
Branches 144 145 +1
==========================================
Hits 281 281
- Misses 478 480 +2
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skjnldsv
approved these changes
May 12, 2026
susnux
approved these changes
May 12, 2026
Contributor
Author
|
Any hints on Cypress failures? CI outputs errors that don't sound related |
Contributor
It does not indeed. |
Contributor
Author
|
I see every open dependabot PR here fails with 1 or 2 of the same Cypress tests. So seems flaky overall |
Contributor
cries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue:
Copy from where PUT request is handled:
nextcloud-upload/lib/uploader/uploader.ts
Lines 661 to 664 in 398a3cd
Haven't tested with bundled app. though response body is the same for PUT and MOVE

