Skip to content

EPP Changes to be committed for 2605 Client release:#877

Open
krzysztofstaszalek wants to merge 4 commits intodevfrom
eppminor20260508
Open

EPP Changes to be committed for 2605 Client release:#877
krzysztofstaszalek wants to merge 4 commits intodevfrom
eppminor20260508

Conversation

@krzysztofstaszalek
Copy link
Copy Markdown
Collaborator

modified:   docs/endpointprotector/admin/cap_module/capai.md
modified:   docs/endpointprotector/admin/cap_module/newoutlook.md
modified:   docs/endpointprotector/index.md
modified:   docs/endpointprotector/install/migrationprocedure/clientupgradediagram.webp
modified:   docs/endpointprotector/install/migrationprocedure/faq.md
modified:   docs/endpointprotector/install/migrationprocedure/migrationguide.md

	modified:   docs/endpointprotector/admin/cap_module/capai.md
	modified:   docs/endpointprotector/admin/cap_module/newoutlook.md
	modified:   docs/endpointprotector/index.md
	modified:   docs/endpointprotector/install/migrationprocedure/clientupgradediagram.webp
	modified:   docs/endpointprotector/install/migrationprocedure/faq.md
	modified:   docs/endpointprotector/install/migrationprocedure/migrationguide.md
bturlea
bturlea previously approved these changes May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Auto-Fix Summary

86 issues fixed, 13 skipped across 5 files

Category Fixes
Contractions 1
FirstPerson (rewrite) 1
OxfordComma (rewrite) 1
Dale: exclamatory-sentences 1
Dale: misplaced-modifiers 1
Dale: passive-voice 64
Dale: positional-references 6
Dale: undefined-acronyms 2
Dale: wordiness 9
Skipped (needs manual review) Reason
docs/endpointprotector/install/migrationprocedure/migrationguide.md:558 — Netwrix.OxfordComma False positive — the comma after 'Statement' ends an introductory clause ('As defined in the Client Supportability Statement,'); 'obsolete and discontinued' is a two-item conjunction in the main clause, not a series of three items requiring an Oxford comma
docs/endpointprotector/admin/cap_module/newoutlook.md:22 — Dale: passive-voice left 'unless the EPP agent is running' and similar passive states inside the warning admonition; rewriting risked changing meaning of the JavaScript-variable behavior description
docs/endpointprotector/admin/cap_module/newoutlook.md:84 — Dale: passive-voice manifest-file description ('At the core of any Office Add-in is the manifest file') uses inversion that's clearer than alternatives; not strictly passive
docs/endpointprotector/install/migrationprocedure/faq.md:28 — Dale: misplaced-modifiers 'Once patched to 2604, the result is functionally equivalent…' has an arguable dangling participle but rewriting risks changing meaning; subject 'the result' is contextually understood
docs/endpointprotector/install/migrationprocedure/faq.md:75 — Dale: xy-slop 'cross-check the count, not just the success status' is a contrast statement, not strictly an x-is-not-y/x-is-z form; meaning would shift if rewritten
docs/endpointprotector/install/migrationprocedure/faq.md:91 — Dale: undefined-acronyms SCIM is a recognized industry standard for identity provisioning; flagging risked over-correcting given the rule's exclusion of well-known IT acronyms
docs/endpointprotector/install/migrationprocedure/faq.md:99 — Dale: undefined-acronyms FQDN is a well-known networking acronym; rule excludes well-known IT industry standards
docs/endpointprotector/install/migrationprocedure/faq.md:188 — Dale: undefined-acronyms ELS for PHP is a license component name where 'ELS' functions as part of the proper-noun product name; defining mid-sentence would change reading
docs/endpointprotector/install/migrationprocedure/migrationguide.md:116 — Dale: undefined-acronyms CRM is a well-known industry term (Customer Relationship Management); skipped per rule guidance on industry-standard acronyms
docs/endpointprotector/install/migrationprocedure/migrationguide.md:618 — Dale: undefined-acronyms MDM is a well-known IT industry acronym (Mobile Device Management) similar to GPO/MFA listed in exclusions
docs/endpointprotector/install/migrationprocedure/migrationguide.md:718 — Dale: undefined-acronyms SCCM is a well-known Microsoft enterprise tool acronym; treating as industry standard
docs/endpointprotector/admin/cap_module/capai.md:73 — Dale: minimizing-difficulty 'integrates seamlessly' describes product behavior, not a user task being minimized; rewriting risked altering meaning of the conclusion
docs/endpointprotector/index.md:28 — Dale: minimizing-difficulty 'seamless management and enforcement' is a marketing-tone borderline case but doesn't minimize a user task; left intact

Ask @claude on this PR if you'd like an explanation of any fix.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Documentation PR Review

Editorial Review

docs/endpointprotector/admin/cap_module/capai.md

  • Clarity — Line 34: "Content Aware Protection (CAP) license with the CAP module enabled" reads tautologically — defining CAP and then immediately referring to "the CAP module" makes the requirement sound circular. Suggested fix: "License that includes the Content Aware Protection (CAP) module".
  • Structure — Line 75: The heading "Example 2: Contextual CAP Policy Triggering on PII patterns in combination for Copilot web & apps" uses inconsistent capitalization compared with "Example 1: Simple CAP Policy Triggering on Credit Card Detection" (Title Case throughout). It also retains an awkward construction ("PII patterns in combination for"). Suggested fix: "Example 2: Contextual CAP Policy Triggering on PII Patterns for Copilot Web and Apps".

docs/endpointprotector/admin/cap_module/newoutlook.md

  • Clarity — Lines 30 and 40: "You need customer portal access to download the EPP content*." The trailing asterisk implies a footnote, but no footnote text appears anywhere on the page. Suggested fix: Remove the stray *, or add the matching footnote text below the section.
  • Completeness — Line 34: "you must address three dependencies collectively" — the list immediately below now contains six numbered items (1, 2, 3, 4, 4, 5), not three. Suggested fix: "you must address the following dependencies collectively" (drop the count, or update it to match the actual number of items).
  • Structure — Lines 67 and 70: After inserting the new item 2 ("Download the latest New Outlook add-in"), the remaining items weren't renumbered, so the source now reads 1, 2, 3, 4, 4, 5. Suggested fix: Renumber "4. Standard EPP Content Aware Protection Policy" to 5. and "5. Deep Packet Inspection Setting" to 6..
  • Structure — Lines 77–79: The new warning admonition "Host these URLs correctly on your server and ensure they're accessible via the internet…" duplicates verbatim the warning already present at line 144 in the Pre-configuring add-in (manifest.xml) section. Placing it inside Requirements is also premature — no URLs have been introduced at that point in the document, so the reader has no referent for "these URLs". Suggested fix: Remove the duplicate warning from the Requirements section; keep only the original instance under Pre-configuring add-in, where the URLs are configured.
  • Clarity — Line 71: "Turn off the setting under Content Aware Protection → Deep Packet Inspection called 'Block Unsupported Protocols in New Outlook'." Leading with the navigation path and trailing with the setting name buries the action target. Suggested fix: "Turn off Block Unsupported Protocols in New Outlook under Content Aware Protection → Deep Packet Inspection."

docs/endpointprotector/index.md

  • No issues found.

docs/endpointprotector/install/migrationprocedure/faq.md

  • No issues found.

docs/endpointprotector/install/migrationprocedure/migrationguide.md

  • Clarity — Line 460: "Re-enable communications after you verify the upgraded server and it's ready to accept traffic." The conjunction joins two unequal clauses (an action + a state), which makes the sentence harder to parse. Suggested fix: "Re-enable communications after you verify that the upgraded server is ready to accept traffic."

Summary

7 editorial suggestions across 5 files (3 files with issues, 2 clean). Vale and Dale issues are auto-fixed separately.


What to do next:

Comment @claude on this PR followed by your instructions to get help:

  • @claude fix all issues — fix all editorial issues
  • @claude help improve the flow of this document — get writing assistance
  • @claude explain the voice issues — understand why something was flagged

You can ask Claude anything about the review or about Netwrix writing standards.

Automated fixes are only available for branches in this repository, not forks.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Auto-Fix Summary

7 issues fixed, 12 skipped across 5 files

Category Fixes
OnceUsage (rewrite) 1
Dale: passive-voice 3
Dale: positional-references 1
Dale: wordiness 2
Skipped (needs manual review) Reason

| docs/endpointprotector/admin/cap_module/capai.md:11 — Dale: passive-voice | 'become increasingly integrated' rewrite would alter the introductory framing of the AI integration trend |
| docs/endpointprotector/admin/cap_module/capai.md:70 — Dale: passive-voice | 'triggered by the URL' is part of a video description bullet narrative; alternative phrasings change technical meaning |
| docs/endpointprotector/admin/cap_module/capai.md:73 — Dale: minimizing-difficulty | 'integrates seamlessly' is video conclusion marketing wording; not clearly a difficulty-minimizing claim about a user task |
| docs/endpointprotector/admin/cap_module/capai.md:122 — Dale: minimizing-difficulty | 'integrates seamlessly' is video conclusion marketing wording; not clearly a difficulty-minimizing claim about a user task |
| docs/endpointprotector/admin/cap_module/newoutlook.md:195 — Dale: positional-references | 'as described in previous chapter' uses temporal/sequential 'previous' rather than spatial 'above'/'below'; not clearly a violation |
| docs/endpointprotector/admin/cap_module/newoutlook.md:211 — Dale: positional-references | 'as described in the previous chapter' uses temporal/sequential 'previous' rather than spatial 'above'/'below'; not clearly a violation |
| docs/endpointprotector/install/migrationprocedure/migrationguide.md:384 — Dale: misplaced-modifiers | 'Use for example Google's public DNS' has misplaced 'for example'; multiple valid rewrites possible without clear winner |
| docs/endpointprotector/install/migrationprocedure/migrationguide.md:454 — Dale: positional-references | 'click Reload above the status column' refers to a literal UI position, not document content |
| docs/endpointprotector/install/migrationprocedure/migrationguide.md:537 — Dale: positional-references | 'still below 5.9.4.3' uses 'below' as a numerical comparison, not a positional document reference |
| docs/endpointprotector/install/migrationprocedure/migrationguide.md:538 — Dale: positional-references | 'still below 5.9.4.3' uses 'below' as a numerical comparison, not a positional document reference |
| docs/endpointprotector/install/migrationprocedure/migrationguide.md:158 — Dale: positional-references | 'disk space is below 30%' uses 'below' as a numerical comparison, not a positional document reference |
| docs/endpointprotector/install/migrationprocedure/migrationguide.md:728 — Dale: passive-voice | 'is rate-limited' is a technical description; rewrite would change meaning or add ambiguity |

Ask @claude on this PR if you'd like an explanation of any fix.

@jth-nw jth-nw temporarily deployed to development May 8, 2026 15:29 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants