PPE fixes and new KB article#873
Conversation
Password Policy Client Displays Generic Message and No PPE Event Is Logged
Auto-Fix Summary2 issues fixed, 3 skipped across 1 files
| Ask |
|
| Category | Fixes |
|---|---|
| Dale: passive-voice | 9 |
| Skipped (needs manual review) | Reason |
|---|
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:11 — Dale: misplaced-modifiers | 'Once configured, these events populate...' is a dangling participle (the integration is configured, not the events), but this construction is idiomatic in technical writing and rewriting risks changing the meaning |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:48 — Dale: passive-voice | 'as long as the key pair is unchanged' — 'is unchanged' reads as state of being; rewriting to 'as long as the key pair doesn't change' could subtly alter the meaning |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:55 — Dale: passive-voice | 'must be installed' in prerequisites list — agent is unknown/unimportant, and 'must install' would require restructuring the bullet |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:57 — Dale: passive-voice | 'TLS certificates must be provisioned' — agent (admin/team) is implied; rewriting could change the imperative tone of the prerequisite |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:138 — Dale: passive-voice | 'when changed from the default' is terse table-prose convention; rewriting could bloat the cell |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:144 — Dale: passive-voice | 'the port configured in NAM agent settings' — past participle as noun modifier, acceptable as adjectival use |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:155 — Dale: passive-voice | 'Events grouped per internal processing batch' — past participle as adjective, not finite passive |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:234 — Dale: passive-voice | 'while disabled' is acceptable shorthand; expanding to 'while ingestion is disabled' adds wordiness without clarity benefit |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:277 — Dale: passive-voice | 'Agents that have been decommissioned or reinstalled' — agent is unknown/varies, passive is appropriate |
Ask @claude on this PR if you'd like an explanation of any fix.
- Fix passive voice, contractions, and third-person usage - Reformat Cause, steps, and Effect sections for readability - Fix broken cross-version links using pathname:// protocol - Add Related Links section - Verified dev build: article loads correctly in sidebar, both links resolve
|
| Category | Fixes |
|---|---|
| Dale: misplaced-modifiers | 1 |
| Dale: passive-voice | 1 |
| Dale: wordiness | 1 |
| Skipped (needs manual review) | Reason |
|---|
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:56 — Dale: passive-voice | 'Netwrix Activity Monitor must be installed and monitoring the hosts...' uses the conventional 'must be' prerequisite-list pattern; rewriting in active voice would either change the meaning (turning a precondition into an instruction) or break parallelism with the other prerequisite bullets in the same list. |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:57 — Dale: passive-voice | 'TLS certificates must be provisioned' / 'paths are set via the environment variables' follow the same prerequisite-list convention as line 56; same parallelism concern. |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:154 — Dale: passive-voice | Table-cell description column ('Maximum events held in memory at once', 'Events grouped per internal processing batch') uses noun-phrase shorthand throughout the table; converting to active voice would break the consistent column style and likely change subjects. |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:164 — Dale: passive-voice | 'after a new connection is established' is conventional and rewriting risks ambiguity about which side establishes the connection (agent connects, listener accepts). |
| docs/accessanalyzer/2601/configurations/activity-monitor-integration.md:244 — Dale: passive-voice | 'environment variables ... are set' is a precondition check; rewriting would either become an instruction or change the verification semantics. |
| docs/passwordpolicyenforcer/11.2/installation/upgrading.md:24 — Dale: wordiness | 'for an extended time' could be tightened to 'for long', but the current phrasing is clear and the trade-off in tone is subjective. |
Ask @claude on this PR if you'd like an explanation of any fix.
hilram7
left a comment
There was a problem hiding this comment.
Review Notes
I reviewed and updated the new KB article (password-policy-client-generic-message-windows-rules.md) before approving. Here is a summary of changes applied and testing results.
Changes Applied
- Fixed contraction (didn't → did not) per KB style guide
- Rewrote passive voice instances throughout
- Changed third-person ("a user") to second-person ("you") per KB style guide
- Reformatted the Cause section into two paragraphs for readability
- Rewrote the intro to the How Password Changes Are Processed section to active voice
- Broke up the dense numbered steps with sub-bullets for readability
- Broke up the Effect on the Password Policy Client section with bullets
- Fixed both internal links to use pathname:// protocol and 11_2 URL format — these were causing build errors because the KB copy script distributes the article to hidden older versions (11.1, 11.0, 10.2), which Docusaurus still compiles even though they are not visible in navigation
- Added Related Links section at the bottom
Testing
- Ran npm run kb:clean && npm run start
- Confirmed article appears in PPE sidebar under Troubleshooting and Errors
- Confirmed both links (Similarity, Disable Windows Rules) resolve correctly
- Dev build passed with no errors
Build Errors to Address
The production build (npm run build) fails on two broken anchors unrelated to the KB article:
- /docs/accessanalyzer/2601/configurations/activity-monitor-integration — links to #launches-the-installation-wizard which does not exist
- /docs/accessanalyzer/2601/install/quickinstall — links to #bring-your-own-certificate-file-requirements which does not exist
These must be fixed before this PR can merge cleanly. The anchor targets should either be added to the destination pages, or the links updated to point to the correct anchors.
jeremymoskowitz-netwrix
left a comment
There was a problem hiding this comment.
Great. Thanks.
f2eab64
Auto-Fix Summary2 issues fixed, 11 skipped across 3 files
| Ask |
jeremymoskowitz-netwrix
left a comment
There was a problem hiding this comment.
Approved !
Documentation PR ReviewEditorial Reviewdocs/accessanalyzer/2601/configurations/activity-monitor-integration.md
docs/passwordpolicyenforcer/11.2/installation/upgrading.md
Summary7 editorial suggestions across 2 files (1 file clean, 6 issues on What to do next: Comment
You can ask Claude anything about the review or about Netwrix writing standards.
|
Auto-Fix Summary2 issues fixed, 6 skipped across 2 files
| Ask |
No description provided.