Skip to content

PPE fixes#864

Merged
toniop-netwrix merged 14 commits intodevfrom
ppe-fixes
May 7, 2026
Merged

PPE fixes#864
toniop-netwrix merged 14 commits intodevfrom
ppe-fixes

Conversation

@toniop-netwrix
Copy link
Copy Markdown
Contributor

No description provided.

@toniop-netwrix toniop-netwrix requested a review from a team as a code owner May 6, 2026 07:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Auto-Fix Summary

0 issues fixed, 0 skipped across 17 files

Ask @claude on this PR if you'd like an explanation of any fix.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Documentation PR Review

Editorial Review

docs/passwordpolicyenforcer/11.2/admin/command_line_interface.md

  • No issues found. (Section deletion only; no added content to review.)

docs/passwordpolicyenforcer/11.2/admin/compromisedpasswordcheck.md

  • No issues found. (Link path updates only.)

docs/passwordpolicyenforcer/11.2/admin/hibpupdater.md

  • No issues found. (File rename, sidebar position update, apostrophe fix, and trailing whitespace cleanup.)

docs/passwordpolicyenforcer/11.2/admin/manage-policies/rules/compromised_rule.md

  • No issues found. (Link path update only.)

docs/passwordpolicyenforcer/11.2/admin/writeback.md

  • No issues found. (File rename, sidebar position update, and trailing whitespace cleanup.)

docs/passwordpolicyenforcer/11.2/index.md

  • No issues found. (Single-word addition aligning supported install targets with the new client install topic.)

docs/passwordpolicyenforcer/11.2/installation/disable_windows_rules.md

  • Clarity — Line 11 vs. Line 33: The intro states "It is therefore recommended to disable the Windows password policy rules while you are experimenting with and testing your PPE configuration," but the note further down opens with "You don't have to disable the Windows password policy rules to use PPE." These two added passages send conflicting signals on the same page. Suggested fix: in the note, lead with the scoping context first — for example, "While disabling the Windows rules is recommended while you test PPE, it isn't required for production use. A password must comply with both the Windows and PPE policies to be accepted."
  • Completeness — Line 35: The added note introduces Fine-Grained Password Policies and Password Settings Objects, but doesn't tell the reader why this matters in the context of disabling Windows rules. Suggested fix: add a leading sentence such as "Even after you set the Default Domain Policy values to 0, FGPPs can still enforce password rules on specific users or groups." so the reader understands why they need to also remove or modify PSOs.

docs/passwordpolicyenforcer/11.2/installation/domain_and_local_policies.md

  • Completeness — Line 19: The added sentence narrows the read-only DC exception to "the [Maximum Age rule], [Password Policy Client], [PPE Web], or Netwrix Password Reset," but the prior version listed "Rules" generically. If only the Maximum Age rule (not the other rules) is impacted on RODCs, that's a meaningful scoping claim that should be made explicit; otherwise, the reader will wonder whether History, Length, etc. also require installation on RODCs. Suggested fix: confirm the rule set and either restore the generic "[Rules]" link or add a brief clause explaining why only Maximum Age applies (for example, "...because the Maximum Age rule is the only rule that runs on RODCs").
  • Completeness — Line 32 and Line 48: The procedure references "Password Policy Enforcer 11.0" (in the registry path) and the Password Policy Enforcer 11.0 Group Policy item, but this document is in the 11.2/ version folder. Readers on 11.2 will look for an 11.0 registry key and step right past the 11.2 one. Suggested fix: update both occurrences to Password Policy Enforcer 11.2 (or use a <version> placeholder if the registry key truly doesn't change across minor releases).

docs/passwordpolicyenforcer/11.2/installation/installationclient.md

  • Structure — Line 14: The note inside the installation overview ends with a paragraph about the Similarity rule ("PPE only enforces the [Similarity rule]... if the user changes their password from the PPC..."). This is a behavior caveat about the rule, not about installing the PPC, and the same point is already made in index.md line 46. Suggested fix: move that sentence to the Similarity rule topic (or keep only in index.md) and let the install-page note focus on the encryption / no-password-storage assurance.
  • Clarity — Line 58–61: The lead-in "If you don't see the rules, then ensure that:" reads awkwardly when each bullet is parsed alongside it (for example, "ensure that: You restarted all domain controllers..."). Suggested fix: rephrase to "If you don't see the rules, check the following:" so the bullets read as standalone troubleshooting items.

docs/passwordpolicyenforcer/11.2/installation/installationgpm.md

  • Structure — Line 24 (Step 3): This step combines the click action with three sentences of branching guidance (Domain Controllers OU vs. workstation OU vs. domain root). Per docs/CLAUDE.md ("Each step is a single action"), readers scanning the procedure will miss the action verb. Suggested fix: split the targeting guidance into a short note or bullet list immediately before step 3, then keep step 3 as a single action: "Right-click the target OU in the left pane, then click Create a GPO in this domain, and Link it here..."
  • Completeness — Line 18 (Step 4 of "Create a Distribution Point"): The previous version had a separate step for downloading and extracting the installation package; the rewrite drops it and goes straight to "Copy the .msi installers to the distribution folder." A reader who hasn't already extracted the package won't know where the .msi files come from. Suggested fix: add a preceding step such as "Download the Password Policy Enforcer installation package from Netwrix and extract the .msi files."

docs/passwordpolicyenforcer/11.2/installation/installationserver.md

  • Structure — Lines 48–50: The fenced code block opens with a leading space ( ```batch), which can break code-block rendering in Docusaurus. Suggested fix: remove the leading space so the fence starts at column 1.
  • Completeness — Line 65: The closing line "Use the REMOVE argument to remove individual components. For example, REMOVE=FeaturePPEMailerServer" is appended after the uninstall code block without a period and without showing how the argument fits into a full msiexec command. A reader can't act on this without an example. Suggested fix: turn it into a complete example, for example: "Use the REMOVE argument to remove individual components. For example, run this command to remove only the Mailer Service: msiexec /i Netwrix_PPE_Server_11.2.0.148_x64.msi REMOVE=FeaturePPEMailerServer /q."
  • Clarity — Line 11: The Configuration Console description ends with "This could be a domain controller, a management server, or your computer." "Your computer" is informal and ambiguous (the reader's workstation? the admin's laptop?). Suggested fix: replace with "your administrative workstation" or a similarly specific term.

docs/passwordpolicyenforcer/11.2/installation/upgrading.md

  • Clarity — Line 14: The link text "Silent Installation" now points to the #automated-deployment anchor on the Server install page. Per docs/CLAUDE.md Vale guidance (WeakLinkText / BoilerplateCrossRef), the link text should reflect what the reader will find at the destination. Suggested fix: rewrite the sentence to match the new heading, for example: "You can also automate installation and uninstallation from the command line. See Automated Deployment for details."
  • Clarity — Line 51: The link text "Install the Password Policy Server" no longer matches the destination page title, which is now "Install the Server Components." Suggested fix: update the link text to "[Install the Server Components]" so the reader sees the heading they expect when they jump to the destination.

docs/passwordpolicyenforcer/11.2/web-overview/installationweb.md

  • No issues found. (File rename, sidebar position update, and trailing whitespace cleanup.)

Summary

11 editorial suggestions across 5 files. The remaining 12 files in the PR are clean (or contain only renames, link path updates, and whitespace cleanup). Vale and Dale issues are auto-fixed separately.


What to do next:

Comment @claude on this PR followed by your instructions to get help:

  • @claude fix all issues — fix all editorial issues
  • @claude help improve the flow of this document — get writing assistance
  • @claude explain the voice issues — understand why something was flagged

You can ask Claude anything about the review or about Netwrix writing standards.

Automated fixes are only available for branches in this repository, not forks.

@toniop-netwrix toniop-netwrix merged commit 662ff66 into dev May 7, 2026
13 of 16 checks passed
@toniop-netwrix toniop-netwrix deleted the ppe-fixes branch May 7, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants