Skip to content

dev to main #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jth-nw merged 9 commits into from
May 1, 2026
Merged

dev to main #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
550b291
fix(vale-autofix): consolidate three auto-fix commits into one
jth-nw Apr 29, 2026
3358d1c
Update activity-monitor-integration.md (#836)
tay-caliguiri Apr 30, 2026
77e97fb
Naa exo support update (#783)
tay-caliguiri Apr 30, 2026
1384b05
Add PPE version 11.2 (#825)
toniop-netwrix May 1, 2026
c924947
fix: replace broken sbpam-url download link with Extras folder refere…
hilram7 May 1, 2026
271df27
fix(vale-autofix): anchor repair after all fixes, covering PR author …
jth-nw May 1, 2026
13e8447
fix(vale-autofix): move anchor check to after all fixes
jth-nw May 1, 2026
5bd3a88
Merge branch 'dev' into fix/vale-autofix-single-commit
jth-nw May 1, 2026
a116d28
Merge pull request #840 from netwrix/fix/vale-autofix-single-commit
jth-nw May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 38 additions & 91 deletions .github/workflows/vale-autofix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,24 +75,6 @@ jobs:
echo "$CHANGED_MD_FILES" > /tmp/changed-files.txt
fi

- name: Check anchor links
id: anchor-check
if: steps.changed-files.outputs.count > 0
continue-on-error: true
run: |
chmod +x scripts/check-anchors.sh
touch /tmp/anchor-errors.txt
BROKEN=0
mapfile -t FILES < /tmp/changed-files.txt
./scripts/check-anchors.sh "${FILES[@]}" > /tmp/anchor-check-output.txt 2>&1 || BROKEN=1
if [ "$BROKEN" -eq 1 ]; then
grep '^\s' /tmp/anchor-check-output.txt > /tmp/anchor-errors.txt || true
BROKEN=$(wc -l < /tmp/anchor-errors.txt | tr -d ' ')
echo "Broken anchors found:"
cat /tmp/anchor-check-output.txt
fi
echo "broken=$BROKEN" >> "$GITHUB_OUTPUT"

- name: Install Vale
if: steps.changed-files.outputs.count > 0
run: |
Expand Down Expand Up @@ -135,28 +117,6 @@ jobs:
echo "fixed=$PHASE1_TOTAL" >> "$GITHUB_OUTPUT"
echo "Phase 1 fixed $PHASE1_TOTAL issue(s)"

- name: Commit Phase 1 fixes
id: phase1-commit
if: steps.phase1.outputs.fixed > 0
run: |
if git diff --quiet; then
echo "committed=false" >> "$GITHUB_OUTPUT"
else
git add -A docs/
git commit -m "fix(vale): auto-fix substitutions and removals"
echo "committed=true" >> "$GITHUB_OUTPUT"
fi

- name: Update heading anchors (Phase 1)
if: steps.phase1-commit.outputs.committed == 'true'
run: |
RESULT=$(bash scripts/vale-autofix.sh --anchors-only 2>&1 || true)
echo "$RESULT"
if ! git diff --quiet; then
git add -A docs/
git commit -m "fix(vale): update anchor links for changed headings"
fi

- name: Re-run Vale for remaining violations
id: vale-remaining
if: steps.vale-initial.outputs.total > 0
Expand Down Expand Up @@ -207,25 +167,7 @@ jobs:
2. Apply a fix that resolves the Vale rule while preserving the author's meaning
3. If you are NOT confident in a fix (ambiguous context, multiple valid interpretations, fix would change meaning) SKIP it

HEADING ANCHOR UPDATES:
When you modify a heading line (any line starting with #), you MUST update all anchor links that reference the old heading.

1. Before editing a heading, record the original heading text
2. Compute the old anchor slug:
- If the heading has a {#custom-id} suffix, use custom-id as the slug
- Otherwise: strip the # prefix and whitespace, lowercase, remove everything except [a-z0-9 -], replace spaces with hyphens, collapse consecutive hyphens, trim leading/trailing hyphens
- Examples: "## Do Not Click" → do-not-click, "## Step 1: Install" → step-1-install, "## Setup {#setup}" → setup
3. After editing, compute the new anchor slug the same way
4. If the slug changed, determine the product/version folder from the file path:
- Multi-version: docs/<product>/<version>/ (e.g., docs/accessanalyzer/12.0/)
- Single-version: docs/<product>/ (e.g., docs/threatprevention/)
- The folder is the first 2 or 3 segments of the path after docs/. If the second segment is a version number (digits/dots), include it.
5. Search ALL .md files in that folder (not just PR-changed files) for link patterns containing #old-slug:
- ](#old-slug) — same-page links
- ](filename#old-slug) — relative links
- ](path/to/filename#old-slug) — deeper relative links
6. Replace #old-slug with #new-slug in every match
7. Include each anchor update in the fixed array of your summary JSON, using the same check value as the heading fix that caused it, with action like "updated anchor link from #old-slug to #new-slug"
Note: if your fixes change any heading text, do not update anchor links — the workflow repairs all anchor links automatically after all fixes are complete.

After fixing, write a JSON summary to /tmp/phase2-summary.json with this structure:
```json
Expand All @@ -239,13 +181,7 @@ jobs:
}
```

After writing the summary, stage and commit your changes:
```bash
git add -A docs/
git commit -m "fix(vale): auto-fix rewrites (AI-assisted)"
```

IMPORTANT: Write the summary JSON file BEFORE committing. Do NOT run git push — the workflow handles pushing. Do not post any PR comments.
IMPORTANT: Write the summary JSON file, then stop. Do NOT run any git commands — the workflow handles staging, committing, and pushing. Do not post any PR comments.
claude_args: '--allowedTools "Bash(git:*),Read,Write,Edit,Glob,Grep"'

- name: Phase 3 — Dale fixes
Expand Down Expand Up @@ -274,25 +210,7 @@ jobs:

Step 4: Fix each violation in-place, preserving the author's meaning. If you are NOT confident in a fix (ambiguous context, multiple valid interpretations, fix would change meaning), SKIP it.

HEADING ANCHOR UPDATES:
When you modify a heading line (any line starting with #), you MUST update all anchor links that reference the old heading.

1. Before editing a heading, record the original heading text
2. Compute the old anchor slug:
- If the heading has a {#custom-id} suffix, use custom-id as the slug
- Otherwise: strip the # prefix and whitespace, lowercase, remove everything except [a-z0-9 -], replace spaces with hyphens, collapse consecutive hyphens, trim leading/trailing hyphens
- Examples: "## Do Not Click" → do-not-click, "## Step 1: Install" → step-1-install, "## Setup {#setup}" → setup
3. After editing, compute the new anchor slug the same way
4. If the slug changed, determine the product/version folder from the file path:
- Multi-version: docs/<product>/<version>/ (e.g., docs/accessanalyzer/12.0/)
- Single-version: docs/<product>/ (e.g., docs/threatprevention/)
- The folder is the first 2 or 3 segments of the path after docs/. If the second segment is a version number (digits/dots), include it.
5. Search ALL .md files in that folder (not just PR-changed files) for link patterns containing #old-slug:
- ](#old-slug) — same-page links
- ](filename#old-slug) — relative links
- ](path/to/filename#old-slug) — deeper relative links
6. Replace #old-slug with #new-slug in every match
7. Include each anchor update in the fixed array of your summary JSON, using the same rule value as the heading fix that caused it, with action like "updated anchor link from #old-slug to #new-slug"
Note: if your fixes change any heading text, do not update anchor links — the workflow repairs all anchor links automatically after all fixes are complete.

Step 5: Write a JSON summary to /tmp/dale-summary.json with this structure:
```json
Expand All @@ -307,15 +225,44 @@ jobs:
```
If no issues found, write: {"fixed": [], "skipped": []}

Step 6: Stage and commit your changes:
```bash
git add -A docs/
git commit -m "fix(dale): auto-fix documentation issues (AI-assisted)"
```
Step 6: Write the summary JSON file (see Step 5 format above), then stop.

IMPORTANT: Write the summary JSON file BEFORE committing. Do NOT run git push — the workflow handles pushing. Do not post any PR comments.
IMPORTANT: Do NOT run any git commands — the workflow handles staging, committing, and pushing. Do not post any PR comments.
claude_args: '--allowedTools "Bash(git:*),Read,Write,Edit,Glob,Grep"'

- name: Fix heading anchors
if: steps.bot-check.outputs.skip != 'true' && steps.changed-files.outputs.count > 0
run: |
bash scripts/vale-autofix.sh --anchors-only origin/dev

- name: Check anchor links
id: anchor-check
if: steps.bot-check.outputs.skip != 'true' && steps.changed-files.outputs.count > 0
continue-on-error: true
run: |
chmod +x scripts/check-anchors.sh
touch /tmp/anchor-errors.txt
BROKEN=0
mapfile -t FILES < /tmp/changed-files.txt
./scripts/check-anchors.sh "${FILES[@]}" > /tmp/anchor-check-output.txt 2>&1 || BROKEN=1
if [ "$BROKEN" -eq 1 ]; then
grep '^\s' /tmp/anchor-check-output.txt > /tmp/anchor-errors.txt || true
BROKEN=$(wc -l < /tmp/anchor-errors.txt | tr -d ' ')
echo "Broken anchors found:"
cat /tmp/anchor-check-output.txt
fi
echo "broken=$BROKEN" >> "$GITHUB_OUTPUT"

- name: Commit all fixes
if: steps.bot-check.outputs.skip != 'true' && steps.changed-files.outputs.count > 0
run: |
git add -A docs/
if git diff --cached --quiet; then
echo "No changes to commit"
else
git commit -m "fix(vale): auto-fix style issues (Vale + Dale)"
fi

- name: Push all fixes
if: steps.bot-check.outputs.skip != 'true' && steps.changed-files.outputs.count > 0
env:
Expand Down
13 changes: 7 additions & 6 deletions docs/accessanalyzer/11.6/requirements/exchange/support/support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ sidebar_position: 10

# Exchange Support and Permissions Explained

This topic outlines what is supported for each type of Exchange version.
This topic outlines support for each Exchange version type.

:::note
Sensitive Data Discovery is available with the EWSMailbox, EWSPublicFolder, and
Expand All @@ -16,7 +16,7 @@ ExchangeMailbox data collectors.

## Support by Data Collector

The following tables provide a breakdown of support by data collector:
The following tables show support by data collector:

| Data Collector | Exchange Online | Exchange 2019 | Exchange 2016 | Exchange 2013 | Exchange 2010 | MAPI-Based |
| -------------------- | --------------- | ------------- | ------------- | ------------- | ------------- | ---------- |
Expand All @@ -33,14 +33,14 @@ The following tables provide a breakdown of support by data collector:

## Support by Job Group

The following tables provide a breakdown of support by job group:
The following tables show support by job group:

| Job Group | Exchange Online | Exchange 2019 | Exchange 2016 | Exchange 2013 | Exchange 2010 | MAPI-Based |
| --------------------- | --------------- | ------------- | ------------- | ------------- | ------------- | ---------- |
| 1. HUB Metrics | No | Yes | Yes | Yes | Yes | No |
| 2. CAS Metrics | No | Yes | Yes | Yes | Yes | No |
| 3. Database | No | Limited\* | Limited\* | Yes | Yes | Yes |
| 4. Mailboxes | Yes | Yes | Yes | Yes | Yes | No |
| 4. Mailboxes | Yes\*\*\* | Yes | Yes | Yes | Yes | No |
| 5. Public Folders | No | No | No | Yes | Yes | Yes |
| 6. Distribution Lists | Yes | Yes | Yes | Yes | Yes | No |
| 7. Sensitive Data | Yes | Yes | Yes | Yes | Limited\* | Mix\*\* |
Expand All @@ -50,10 +50,11 @@ The following tables provide a breakdown of support by job group:

\*\* Mix indicates some data collectors are MAPI-based, but not all.

\*\*\* The **Logons** sub-group (part of job group 4. Mailboxes) isn't compatible with Exchange Online targets. For the Exchange Online version of this group, use 8. Exchange Online > Mailboxes.

## Exchange Solution to Permissions Alignment

See the following sections for permission requirements according to the job group, data collector,
or action module to be used:
See the following sections for permission requirements by job group, data collector, or action module:

- [Exchange Mail-Flow Permissions](/docs/accessanalyzer/11.6/requirements/exchange/support/mailflow.md)

Expand Down
13 changes: 7 additions & 6 deletions docs/accessanalyzer/12.0/requirements/exchange/support/support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ sidebar_position: 10

# Exchange Support and Permissions Explained

This topic outlines what is supported for each type of Exchange version.
This topic outlines support for each Exchange version type.

:::note
Sensitive Data Discovery is available with the EWSMailbox, EWSPublicFolder, and
Expand All @@ -16,7 +16,7 @@ ExchangeMailbox data collectors.

## Support by Data Collector

The following tables provide a breakdown of support by data collector:
The following tables show support by data collector:

| Data Collector | Exchange Online | Exchange 2019 | Exchange 2016 | Exchange 2013 | Exchange 2010 | MAPI-Based |
| -------------------- | --------------- | ------------- | ------------- | ------------- | ------------- | ---------- |
Expand All @@ -33,14 +33,14 @@ The following tables provide a breakdown of support by data collector:

## Support by Job Group

The following tables provide a breakdown of support by job group:
The following tables show support by job group:

| Job Group | Exchange Online | Exchange 2019 | Exchange 2016 | Exchange 2013 | Exchange 2010 | MAPI-Based |
| --------------------- | --------------- | ------------- | ------------- | ------------- | ------------- | ---------- |
| 1. HUB Metrics | No | Yes | Yes | Yes | Yes | No |
| 2. CAS Metrics | No | Yes | Yes | Yes | Yes | No |
| 3. Database | No | Limited\* | Limited\* | Yes | Yes | Yes |
| 4. Mailboxes | Yes | Yes | Yes | Yes | Yes | No |
| 4. Mailboxes | Yes\*\*\* | Yes | Yes | Yes | Yes | No |
| 5. Public Folders | No | No | No | Yes | Yes | Yes |
| 6. Distribution Lists | Yes | Yes | Yes | Yes | Yes | No |
| 7. Sensitive Data | Yes | Yes | Yes | Yes | Limited\* | Mix\*\* |
Expand All @@ -50,10 +50,11 @@ The following tables provide a breakdown of support by job group:

\*\* Mix indicates some data collectors are MAPI-based, but not all.

\*\*\* The **Logons** sub-group (part of job group 4. Mailboxes) isn't compatible with Exchange Online targets. For the Exchange Online version of this group, use 8. Exchange Online > Mailboxes.

## Exchange Solution to Permissions Alignment

See the following sections for permission requirements according to the job group, data collector,
or action module to be used:
See the following sections for permission requirements by job group, data collector, or action module:

- [Exchange Mail-Flow Permissions](/docs/accessanalyzer/12.0/requirements/exchange/support/mailflow.md)

Expand Down
Loading
Loading