Update filter combination logic in overview.md#314
Update filter combination logic in overview.md#314konstantin-melnikov-docs merged 6 commits intodevfrom
Conversation
Clarified the logical operators used in filter combinations for search functionality.
pavelshabanov2025
had a problem deploying
to
development
GitHub Actions
Error
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Issues in PR changes
- Line 82: Remove single quotes around 'OR' - logical operators should not be quoted. Change
'OR' logical operatortoOR logical operator. - Line 83: Remove single quotes around 'AND' - logical operators should not be quoted. Change
'AND' logical operatortoAND logical operator. - Line 84: Remove single quotes around 'AND' - logical operators should not be quoted. Change
the logical operator 'AND'tothe logical operator AND. - Line 84: Redundant phrase. Change
regardless of whether they are of the same type or nottoregardless of type. - Line 84: Inconsistent capitalization in operator names. Change
Not equal to; Does not contain; Not in groupto maintain consistency with lowercase articles.
Preexisting issues
- Line 42: Missing space before "for more information". Change
Discovery ](/docs/auditor/10.8/admin/settings/sensitivedatadiscovery.md)for more information.toDiscovery](/docs/auditor/10.8/admin/settings/sensitivedatadiscovery.md) for more information. - Line 59: Typo. Change
fecthtofetch. - Line 66: Typo. Change
retrieveingtoretrieving. - Line 92: Typo. Change
ActionnabletoActionable. - Line 98: Typo. Change
User AtivitytoUser Activity. - Line 148: Typo. Change
ActionnabletoActionable.
There are two ways to apply fixes:
- View them in the comments and apply them individually or in a batch. This only applies to changes made to the file.
- Reply with
@claudehere, followed by your instructions (e.g.@claude fix all issuesor@claude fix only the spelling errorsor@claude fix all other existing issues). You can use this option to fix preexisting issues.
Note: Automated fixes are only available for branches in this repository, not forks.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pavelshabanov2025
temporarily deployed
to
development
GitHub Actions
Inactive
There was a problem hiding this comment.
Issues in PR changes
- Line 81: Use active voice instead of passive. Change "the combination of conditions occurs" to "Netwrix Auditor combines conditions"
- Line 82: Missing article before "OR logical operator" — add "the"
- Line 82: Use active voice. Change "are combined using" to "combine with"
- Line 82: Capitalize sentence start. Change "filters" to "Filters"
- Line 83: Missing article before "AND logical operator" — add "the"
- Line 83: Use active voice. Change "are combined using" to "combine with"
- Line 83: Capitalize sentence start. Change "filters" to "Filters"
- Line 84: Use active voice. Change "are combined using the logical operator AND" to "combine with the AND logical operator"
- Line 84: Format list items consistently. Change semicolons to commas in "not equal to; does not contain; not in group"
Preexisting issues
- Line 42: Missing space. Change "sensitivedatadiscovery.md)for" to "sensitivedatadiscovery.md) for"
- Line 59: Spelling error. Change "fecth" to "fetch"
- Line 66: Spelling error. Change "retrieveing" to "retrieving"
- Line 92: Spelling error. Change "Actionnable" to "Actionable"
- Line 98: Spelling error. Change "Ativity" to "Activity"
- Line 148: Spelling error. Change "Actionnable" to "Actionable"
There are two ways to apply fixes:
- View them in the comments and apply them individually or in a batch. This only applies to changes made to the file.
- Reply with
@claudehere, followed by your instructions (e.g.@claude fix all issuesor@claude fix only the spelling errorsor@claude fix all other existing issues). You can use this option to fix preexisting issues.
Note: Automated fixes are only available for branches in this repository, not forks.
pavelshabanov2025
temporarily deployed
to
development
GitHub Actions
Inactive
There was a problem hiding this comment.
Issues in PR changes
- Line 42: Trailing space in link text. "[Sensitive Data Discovery ]" should be "[Sensitive Data Discovery]" (remove trailing space before closing bracket).
- Line 59: Incorrect article usage. "run the variety of search queries" should be "run a variety of search queries" for proper grammar.
- Line 84: Inconsistent phrasing of logical operator. "combined using the logical operator AND" should be "combined using the AND logical operator" to match the style used in lines 82-83.
- Line 92: Missing link markup. "See Make Search Results Actionable for more information" should be a proper markdown link like other cross-references in the document.
Preexisting issues
- Line 62: Missing article. "click Search button" should be "click the Search button".
- Line 104: Incorrect relative pronoun. "the activity record which details you want to review" should be "the activity record whose details you want to review" (use "whose" for possessive).
- Line 106: Inconsistent UI element formatting. "Full screen..." link should be bolded as Full screen... to match other UI element references.
- Line 109: Missing word and inconsistent formatting. "clicking the Show video on the right" should be "clicking the Show video link on the right".
- Line 111-112: Incomplete sentence. "as described in the Include and Exclude Data" is missing a proper section reference. Should be "as described in the Include and Exclude Data section" or similar.
- Line 151: Subject-verb disagreement. "delivery of this search results" should be "delivery of these search results" or "delivery of the search results".
There are two ways to apply fixes:
- View them in the comments and apply them individually or in a batch. This only applies to changes made to the file.
- Reply with
@claudehere, followed by your instructions (e.g.@claude fix all issuesor@claude fix only the spelling errorsor@claude fix all other existing issuesor@claude fix all linting issues). You can use this option to fix preexisting issues.
Note: Automated fixes are only available for branches in this repository, not forks.
Corrected minor grammatical errors and improved clarity in the search overview documentation.
pavelshabanov2025
had a problem deploying
to
development
GitHub Actions
Error
There was a problem hiding this comment.
Issues in PR changes
- Line 92: Link contains incorrect version format and misspelled anchor. The URL uses
10_8(underscore) instead of10.8(period), and the anchor is#make-search-results-actionnableinstead of#make-search-results-actionable. Fix: change/docs/auditor/10_8/admin/search/overview#make-search-results-actionnableto/docs/auditor/10.8/admin/search/overview#make-search-results-actionable.
Preexisting issues
-
Line 88: UI element not formatted consistently. "Open in new window" should be bolded. Fix: change "click Open in new window" to "click Open in new window".
-
Line 106: UI element not formatted consistently. "Full screen..." should be bolded. Fix: change "click the Full screen..." to "click the Full screen...".
-
Line 108: UI element not formatted consistently. "Show video..." should be bolded. Fix: change "click the Show video..." to "click the Show video...".
-
Line 109: UI element not formatted consistently. "Show video" should be bolded. Fix: change "clicking the Show video" to "clicking the Show video".
-
Line 112-113: Incomplete sentence. The sentence "You can instruct Netwrix Auditor to include or exclude this activity record from the search query results, as described in the Include and Exclude Data" ends abruptly without proper completion. Fix: add "section." at the end or revise to make the sentence complete.
-
Line 121: UI element not formatted consistently. "Tools" should be bolded. Fix: change "Navigate to Tools" to "Navigate to Tools".
-
Line 122: UI element not formatted consistently. "Select columns" should be bolded. Fix: change "Click Select columns" to "Click Select columns".
-
Line 128: UI element not formatted consistently. "Restore Default" should be bolded. Fix: change "click Restore Default" to "click Restore Default".
-
Line 138: Missing punctuation. The heading "To include or exclude data" should end with a colon for consistency with procedural headings. Fix: change "To include or exclude data" to "To include or exclude data:".
-
Line 142: UI elements not formatted consistently. "Exclude from search" and "Include to search" should be bolded. Fix: change "Click Exclude from search or Include to search" to "Click Exclude from search or Include to search".
-
Line 153: UI element not formatted consistently. "Tools" should be bolded. Fix: change "Navigate to Tools" to "Navigate to Tools".
There are two ways to apply fixes:
- View them in the comments and apply them individually or in a batch. This only applies to changes made to the file.
- Reply with
@claudehere, followed by your instructions (e.g.@claude fix all issuesor@claude fix only the spelling errorsor@claude fix all other existing issuesor@claude fix all linting issues). You can use this option to fix preexisting issues.
Note: Automated fixes are only available for branches in this repository, not forks.
Corrected the formatting of the 'Tools' section and fixed a link typo in the search overview documentation.
pavelshabanov2025
temporarily deployed
to
development
GitHub Actions
Inactive
There was a problem hiding this comment.
Issues in PR changes
-
Line 62: Incorrect preposition. "by all monitoring plans" should be "from all monitoring plans" or "collected by all monitoring plans". The preposition "by" suggests agency rather than source.
-
Line 84: Inconsistent formatting of operator names. The operator names (not equal to, does not contain, not in group) should be formatted consistently using quotes or bold formatting for clarity and to distinguish them as UI elements or technical terms.
-
Line 92: Broken internal link. The URL path uses "/docs/auditor/10_8/" with an underscore instead of "/docs/auditor/10.8/" with a period, making this link non-functional. All other links in the document use the period separator.
-
Line 151: Comma splice creating a run-on sentence. The sentence lists four actions separated only by commas. Add "and" before the final clause: "subscribe to periodic delivery of these search results, and create a search-based alert."
Preexisting issues
-
Line 44: Awkward construction with redundant phrasing. "against data stored in the audit databases, that is, on data collected" uses "that is" to restate the same concept, creating wordiness. Consider rephrasing to eliminate the redundancy.
-
Line 47: Missing article. "See [Investigations]... topic" should include the article "the" before the link: "See the [Investigations]... topic for additional information."
-
Line 88: Unformatted UI element. "Open in new window" refers to a UI control and should be formatted in bold: Open in new window.
-
Line 104: Incorrect relative pronoun. "the activity record which details you want to review" should use the possessive "whose" instead of "which": "the activity record whose details you want to review."
-
Line 106: Unformatted UI element. "Full screen..." is a link or button label and should be formatted in bold: Full screen....
-
Line 108-109: Unformatted UI elements. "Show video..." appears twice as a UI element (link and button) and should be formatted in bold both times: Show video....
-
Line 111-112: Incomplete sentence. The sentence ends abruptly with "as described in the Include and Exclude Data" without completing the reference. Add "section" or convert to a proper link reference.
-
Line 121: Unformatted UI element. "Tools" refers to a menu or UI control and should be formatted in bold: Tools (this was corrected later in line 153 but not here).
-
Line 160: Missing article. "large amount of data" should include the article "a": "a large amount of data".
-
Line 167: Informal imperative. "Make sure that" is conversational. Use "Verify that" or "Ensure that" for professional technical documentation.
-
Line 168: Informal imperative. "Check" is conversational. Use "Verify" or "Review" for professional technical documentation.
There are two ways to apply fixes:
- View them in the comments and apply them individually or in a batch. This only applies to changes made to the file.
- Reply with
@claudehere, followed by your instructions (e.g.@claude fix all issuesor@claude fix only the spelling errorsor@claude fix all other existing issuesor@claude fix all linting issues). You can use this option to fix preexisting issues.
Note: Automated fixes are only available for branches in this repository, not forks.
konstantin-melnikov-docs
had a problem deploying
to
development
GitHub Actions
Error
There was a problem hiding this comment.
Documentation Review
No summary was generated.
There are two ways to apply fixes:
- View them in the comments and apply them individually or in a batch. This only applies to changes made to the file.
- Reply with
@claudehere, followed by your instructions (e.g.@claude fix all issuesor@claude fix only the spelling errorsor@claude fix all other existing issuesor@claude fix all linting issues). You can use this option to fix preexisting issues.
Note: Automated fixes are only available for branches in this repository, not forks.
Co-authored-by: Claude Code <claude-code@kilocode.dev>
konstantin-melnikov-docs
force-pushed
the
search-filters-combinations
branch
from
9d9dcc7 to
e1aca61
Compare
konstantin-melnikov-docs
deployed
to
development
GitHub Actions
Active
There was a problem hiding this comment.
Issues in PR changes
None.
Preexisting issues
-
docs/accessanalyzer/12.0/install/application/reports/okta.md:9 – Text "Create an Access Analyzer Application in Okta Using the WS-Fed Template" appears as plain text but functions as a section heading. Convert to proper heading with ## prefix.
-
docs/accessanalyzer/12.0/install/application/reports/okta.md:25 – Text "Retrieve the Values to Paste into the Access Analyzer WebServer.exe.config File" appears as plain text but functions as a section heading. Convert to proper heading with ## prefix.
-
docs/accessanalyzer/12.0/install/application/reports/okta.md:45 – Text "Edit the WebServer.exe.config File" appears as plain text but functions as a section heading. Convert to proper heading with ## prefix.
-
docs/accessanalyzer/12.0/install/application/reports/okta.md:85 – Code example shows
<add key="WsFederationMetadata"in the WSFederationReply section. The key name should beWsFederationReplyto match the parameter being configured, notWsFederationMetadata. -
docs/accessanalyzer/12.0/install/application/reports/okta.md:90 – Text "Configure the App Settings for the StealthAUDIT Application" uses inconsistent product name "StealthAUDIT". Change to "Access Analyzer" for consistency with the rest of the document. Also convert from bold text to proper ## heading.
-
docs/accessanalyzer/12.0/install/application/reports/okta.md:121 – Image alt text contains typo "Atrribute". Change to "Attribute".
-
docs/auditor/10.8/admin/search/overview.md:111 – Sentence ends incomplete: "as described in the Include and Exclude Data". Add "section" or convert to proper section reference link.
-
docs/passwordpolicyenforcer/11.1/installation/hibpupdater.md:128 – Warning text contains unclear punctuation: "%SystemRoot%. hash files". Remove the period after "%SystemRoot%" or rephrase for clarity.
There are two ways to apply fixes:
- View them in the comments and apply them individually or in a batch. This only applies to changes made to the file.
- Reply with
@claudehere, followed by your instructions (e.g.@claude fix all issuesor@claude fix only the spelling errorsor@claude fix all other existing issuesor@claude fix all linting issues). You can use this option to fix preexisting issues.
Note: Automated fixes are only available for branches in this repository, not forks.
2 participants
Clarified the logical operators used in filter combinations for search functionality.