feat: suppress spinner in watch command with --silent flag#7770
Open
egvr2002 wants to merge 1 commit intonetlify:mainfrom
Open
feat: suppress spinner in watch command with --silent flag#7770egvr2002 wants to merge 1 commit intonetlify:mainfrom
egvr2002 wants to merge 1 commit intonetlify:mainfrom
Conversation
5bea43a to
c52d425
Compare
Contributor
What kind of testing did you do in order to verify? Can you add additional tests to ensure proper functionality here? |
Author
|
I manually tested only since I didn't find any integration or unit test for this command. But no problem! I'll work on this and add some testing, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5301
This issue was opened a long time ago, so I don't really know if my fix still applies. However, I decided to work on this and send this PR.
This PR suppresses the animated spinner in
netlify watchwhen the--silentflag is used, preventing continuous terminal activity notifications in some terminal multiplexers like tmux, screen, etc.However, I have some questions about this feature:
console.time('Deploy time')/console.timeEnd('Deploy time')also respect the--silentflag?watchcommand currently doesn't have a--jsonoption implemented. Should I add it as part of this PR?LMK if you need anything else. I'm open to feedback if the approach or requirements have changed. 😃
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.