fix(converter): fall back to native aac encoder when libfdk_aac unavailable#990
Open
berettavexee wants to merge 1 commit into
Open
fix(converter): fall back to native aac encoder when libfdk_aac unavailable#990berettavexee wants to merge 1 commit into
berettavexee wants to merge 1 commit into
Conversation
…ilable libfdk_aac is not included in most standard FFmpeg builds. Detect availability once at import time and use the built-in aac encoder as fallback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
I forgot to include a info message when it fall back on the FFMPEG AAC lib. This might be of interest to someone, although, to be honest, the difference in encoding quality at 256 kbps is negligible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
libfdk_aacis not included in most standard FFmpeg builds (Ubuntu, Debian, Homebrew without--with-fdk-aac…). When a user runsrip -c aac, the conversion silently fails because FFmpeg exits with an error when it can't find the encoder — and with-loglevel panicthe output is suppressed, making the error opaque.Fix
Detect
libfdk_aacavailability once at module import time usingffmpeg -encoders. If unavailable, fall back to the built-in nativeaacencoder which ships with every standard FFmpeg build.Test plan
libfdk_aac:AAC.codec_lib == "libfdk_aac"(unchanged behaviour)libfdk_aac(most users):AAC.codec_lib == "aac", conversion succeedsrip -c aac url <url>produces.m4afiles without errors🤖 Generated with Claude Code