feat(cli): expose OPUS codec in -c option#989
Open
berettavexee wants to merge 1 commit into
Open
Conversation
The converter.OPUS class already existed but was excluded from the CLI validation and help text. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
I must be one of only two people on earth who use the Opus codec. I’ve just realised that conversion is partially supported. Here’s a two-line patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
converter.OPUSclass already existed and was fully implemented (usinglibopus, container.opus, default bitrate128k), and was registered inconverter.get(). However it was silently excluded from the CLI-c/--codecoption by the validation assert and the help text.This PR makes OPUS available without adding any new code:
"OPUS"to the allowed values in theassertinrip/cli.py--codechelp string to mention OPUSTest plan
rip url <deezer_track_url> -c opus→ file downloaded and converted to.opusrip --helpshows OPUS in the codec list🤖 Generated with Claude Code