Add download of deezer lyrics#984
Open
leonard-slass wants to merge 3 commits into
Open
Conversation
Fetch lyrics from Deezer's GW endpoint (song.getLyrics) in DeezerClient.get_track and thread them through TrackMetadata.from_deezer, mirroring the existing Tidal lyrics flow. Failures are logged and do not abort the download. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add a `lyrics` option (default true) to the [downloads] config section that gates lyrics fetching for both Deezer and Tidal. The dataclass field is defaulted so configs written before this option still load without a version bump. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Build LRC-formatted text from LYRICS_SYNC_JSON in the song.getLyrics response, falling back to plain LYRICS_TEXT when a track has no sync data. Mirrors the Tidal behavior of using unsynced lyrics when conversion to MP3 is enabled. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Thomas,
This PR adds the following:
lyricswhich defaults to true, if false the lyrics are not downloadedTake care,
Leonard