fix(qobuz): close session when login() raises to avoid unclosed connector warnings#1005
Open
berettavexee wants to merge 1 commit into
Open
fix(qobuz): close session when login() raises to avoid unclosed connector warnings#1005berettavexee wants to merge 1 commit into
berettavexee wants to merge 1 commit into
Conversation
…ctor warnings Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
QobuzClient.login()raises an exception (e.g.AuthenticationErroron HTTP 401,MissingCredentialsError,InvalidAppIdError,IneligibleError, or any network error), theaiohttp.ClientSessioncreated at the top of the method is never closed.This produces the following warnings in the log:
Fix
Wrap the body of
login()in atry/except Exceptionblock that closes the session before re-raising. If login succeeds the session stays open as before; if it fails the connector is cleaned up immediately.Notes
self.session = ..., making it unreachable by Python) has been moved to the correct position at the top of the method