fix(test): use Pop/Rock genre in Qobuz fixture to exercise genre splitting#1001
Open
berettavexee wants to merge 1 commit into
Open
fix(test): use Pop/Rock genre in Qobuz fixture to exercise genre splitting#1001berettavexee wants to merge 1 commit into
berettavexee wants to merge 1 commit into
Conversation
…ting The test asserts both "Pop" and "Rock" are present after parsing, which requires a slash-separated genre name. The fixture had only "Rock", making the split test meaningless and the Pop assertion impossible to pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_album_metadata_qobuzhas been failing because the fixtureqobuz_album_resp.jsonsets the genre name to"Rock", but the test asserts both"Pop"and"Rock"are present in the parsed genre list.The
from_qobuzparser uses a regex ([^→\/]+) to split genre names on/and→separators. With"Rock"as the genre name, no splitting occurs and only["Rock"]is returned — making the"Pop" in m.genreassertion always fail.Changing the fixture genre to
"Pop/Rock"makes the parser produce["Pop", "Rock"], which:Test plan
test_album_metadata_qobuzpassestest_track_metadata_qobuzstill passes🤖 Generated with Claude Code