Skip to content

Update nuspec to place library under nano TFM#39

Closed
Copilot wants to merge 4 commits intodevelopfrom
copilot/update-nuspec-for-nano-tfm
Closed

Update nuspec to place library under nano TFM#39
Copilot wants to merge 4 commits intodevelopfrom
copilot/update-nuspec-for-nano-tfm

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 11, 2026

  • Updated nanoFramework.System.Security.Cryptography.nuspec to align with develop branch:
    • Wrapped dependency in <group targetFramework=".NETnanoFramework1.0"> element
    • Replaced individual file entries (dll, pdb, pdbx, pe, xml) with a single wildcard entry targeting lib\netnano1.0
    • Updated CoreLibrary version to match develop branch (2.0.0-preview.35)
Original prompt

This section details on the original issue you should resolve

<issue_title>Update nuspec to place library under nano TFM</issue_title>
<issue_description>### Details about task
Most of the nuspec files are not using the correct location to place the files.
Files (DLL, PE, PDBX and XML for IntelliSense) should be placed under "lib\netnano1.0" (currently are being placed under "lib" only.
Also they should declare a dependency group for ".NETnanoFramework1.0" target framework.
At the same time those still naming the various file types should use a wildcard instead (e.g. "...\Release\mscorlib.*).
The correct pattern should be (take this nuspec as sample):
nanoframework/System.Device.Adc@aab7bca

Do not change anything else on the nuspec file.

Description

</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: josesimoes <1881520+josesimoes@users.noreply.github.com>
Copilot AI changed the title [WIP] Update nuspec to place library under nano TFM Update nuspec to place library under nano TFM Mar 11, 2026
@josesimoes josesimoes marked this pull request as ready for review March 11, 2026 12:03
@josesimoes
Copy link
Copy Markdown
Member

@copilot this should be done against develop branch

@sonarqubecloud
Copy link
Copy Markdown

Co-authored-by: josesimoes <1881520+josesimoes@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Mar 11, 2026

@copilot this should be done against develop branch

I've updated the branch so the nuspec uses the develop branch's CoreLibrary version (2.0.0-preview.35) — commit 57e4b65. The PR base branch needs to be changed from main to develop (which I'm unable to do directly). Once that's done, the diff will show only the structural changes: dependency group + wildcard file pattern targeting lib\netnano1.0.

@josesimoes josesimoes changed the base branch from main to develop March 11, 2026 12:12
@josesimoes
Copy link
Copy Markdown
Member

@copilot rebase this PR, it should only show diffs in nuspec file

@josesimoes josesimoes closed this Mar 11, 2026
@nfbot nfbot added the invalid This doesn't seem right label Mar 11, 2026
Copilot stopped work on behalf of josesimoes due to an error March 11, 2026 14:06
@josesimoes josesimoes deleted the copilot/update-nuspec-for-nano-tfm branch March 11, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update nuspec to place library under nano TFM

3 participants