Conversation
- toggle_model.go: the comment named ToggleModelEndpoint; the function is ToggleStateModelEndpoint. - message.go: the comment named MessagesToProto; the method is (Messages).ToProto. - galleryop/service.go: the doc comment used the pre-export name newUserCancellableContext; the function is NewUserCancellableContext. - pkg/sound/int16.go: calculateRMS16 -> CalculateRMS16. Each old name appears nowhere else in the repo (verified with repo-wide grep). Assisted-by: ZCode:GLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Four doc comments still reference pre-rename symbols that no longer exist anywhere in the repo:
core/http/endpoints/localai/toggle_model.go:14:ToggleModelEndpoint→ToggleStateModelEndpointcore/schema/message.go:74:MessagesToProto→ToProtocore/services/galleryop/service.go:525:newUserCancellableContext→NewUserCancellableContext(the same comment block already used the new name a few lines below)pkg/sound/int16.go:16:calculateRMS16→CalculateRMS16Why
Each old name survives only in its comment (verified with repo-wide grep), so godoc and code navigation point contributors at symbols that don't exist.
Comment-only change, no behavior impact.