Skip to content

fix(tests): align openresponses test model name with GGUF-derived naming (#10589)#10609

Merged
mudler merged 1 commit into
masterfrom
fix/openresponses-test-model-name
Jun 30, 2026
Merged

fix(tests): align openresponses test model name with GGUF-derived naming (#10589)#10609
mudler merged 1 commit into
masterfrom
fix/openresponses-test-model-name

Conversation

@localai-bot

Copy link
Copy Markdown
Collaborator

Why master is red

The tests workflow has failed on every master push since 1a4f68ed4 (it was green at the immediately preceding 28d739774). The breaking change is #10589fix(import): derive model name from selected GGUF for repo-root URIs.

Five specs in the Open Responses API suite (core/http/openresponses_test.go) fail because POST /v1/responses returns 404:

  • HTTP Protocol Compliance → MUST accept application/json Content-Type
  • Content Types → MUST support input_text content
  • Content Types → MUST support input_image content with URL
  • Content Types → MUST support input_image content with base64
  • Previous Response ID → should return error for invalid previous_response_id

Root cause

The test loads a model from https://huggingface.co/unsloth/Qwen3-VL-2B-Instruct-GGUF (a repo-root URI) and then addresses it with the hard-coded name Qwen3-VL-2B-Instruct-GGUF. #10589 intentionally changed repo-root imports to name the model after the selected GGUF file rather than the repository. With the default quant (q4_k_m), the importer now registers the model as Qwen3-VL-2B-Instruct-Q4_K_M (confirmed in the CI logs). The old name no longer resolves, so the model-resolution middleware 404s — outside the test's accepted 200/400/500 set.

#10589 updated its own importers_test.go but missed this unrelated integration test.

Fix

The behaviour change is correct; only the stale test constant needed updating. One line:

const testModel = "Qwen3-VL-2B-Instruct-Q4_K_M"   // was "Qwen3-VL-2B-Instruct-GGUF"

testModel is referenced everywhere in the file via the constant; the WithModelsURL source repo is unchanged (only the registered name changed).

…ing (#10589)

PR #10589 changed repo-root HuggingFace URI imports to name the model after
the selected GGUF file rather than the repository. The Open Responses API
integration test still requested the old repo-derived name
("Qwen3-VL-2B-Instruct-GGUF"), so every request 404'd on an unknown model and
the suite has failed on master since 1a4f68e.

Update testModel to the name the importer now registers for the default
q4_k_m quant ("Qwen3-VL-2B-Instruct-Q4_K_M") so the specs resolve the model
again. The #10589 behaviour change is intentional; only the stale test needed
updating.

Assisted-by: Claude:claude-opus-4-8 [Claude Code]

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
@mudler mudler merged commit d74f883 into master Jun 30, 2026
61 checks passed
@mudler mudler deleted the fix/openresponses-test-model-name branch June 30, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants