fix(tests): align openresponses test model name with GGUF-derived naming (#10589)#10609
Merged
Conversation
…ing (#10589) PR #10589 changed repo-root HuggingFace URI imports to name the model after the selected GGUF file rather than the repository. The Open Responses API integration test still requested the old repo-derived name ("Qwen3-VL-2B-Instruct-GGUF"), so every request 404'd on an unknown model and the suite has failed on master since 1a4f68e. Update testModel to the name the importer now registers for the default q4_k_m quant ("Qwen3-VL-2B-Instruct-Q4_K_M") so the specs resolve the model again. The #10589 behaviour change is intentional; only the stale test needed updating. Assisted-by: Claude:claude-opus-4-8 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why master is red
The
testsworkflow has failed on every master push since1a4f68ed4(it was green at the immediately preceding28d739774). The breaking change is #10589 —fix(import): derive model name from selected GGUF for repo-root URIs.Five specs in the Open Responses API suite (
core/http/openresponses_test.go) fail becausePOST /v1/responsesreturns 404:HTTP Protocol Compliance→ MUST accept application/json Content-TypeContent Types→ MUST support input_text contentContent Types→ MUST support input_image content with URLContent Types→ MUST support input_image content with base64Previous Response ID→ should return error for invalid previous_response_idRoot cause
The test loads a model from
https://huggingface.co/unsloth/Qwen3-VL-2B-Instruct-GGUF(a repo-root URI) and then addresses it with the hard-coded nameQwen3-VL-2B-Instruct-GGUF. #10589 intentionally changed repo-root imports to name the model after the selected GGUF file rather than the repository. With the default quant (q4_k_m), the importer now registers the model asQwen3-VL-2B-Instruct-Q4_K_M(confirmed in the CI logs). The old name no longer resolves, so the model-resolution middleware 404s — outside the test's accepted200/400/500set.#10589 updated its own
importers_test.gobut missed this unrelated integration test.Fix
The behaviour change is correct; only the stale test constant needed updating. One line:
testModelis referenced everywhere in the file via the constant; theWithModelsURLsource repo is unchanged (only the registered name changed).