This repository was archived by the owner on Jun 10, 2018. It is now read-only.
Minor PHP Snippet Suggestions#47
Open
ddelrio1986 wants to merge 2 commits intomsanders:masterfrom
ddelrio1986:master
Open
Minor PHP Snippet Suggestions#47ddelrio1986 wants to merge 2 commits intomsanders:masterfrom ddelrio1986:master
ddelrio1986 wants to merge 2 commits intomsanders:masterfrom
ddelrio1986:master
Conversation
phpdoc. I also changed one ending from *// to */ as it seems that was an error.
Author
|
Just wondering if you ever had a moment to look over this? |
Author
|
Any reason why this PR was ignored? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first pull request so if I did something wrong please let me know. phpdoc is almost the standard automatic docblock parser (not official but basically what everyone uses) for php. It shows the ending of all docblocks to be / instead of */. So I changed this in the snippets.
I also noticed one snippet which was missing a space that would cause my vim to go crazy and freeze/lag when I tried to use some snippets. The space wasn't missing in the /* snippet but it seemed to still cause vim to freeze up when I used that snippet.
I also noticed that one docblock had @packaged which isn't a valid docblock tag that I've seen so I changed it to @Package.