This repository was archived by the owner on Sep 14, 2023. It is now read-only.
Open
Conversation
mre
reviewed
Jun 3, 2018
| def test_hyperjson(self): | ||
| # FIXME: hyperjson does not have any of this | ||
| pass | ||
| # self.assertEqual(self.json.scanner.make_scanner.__module__, 'hyperjson') |
Owner
There was a problem hiding this comment.
No clue what these scanner things are. I guess we should document that incompatibility somewhere. 🤔
Owner
|
@wdv4758h, could you merge the master into this branch? Maybe that fixes a few more tests now. I'd love to get this merged. 😉 🍷 |
Contributor
Author
|
@mre I've merged current master in. Current result: |
Contributor
Author
|
There are some parameters in standard libarary's |
Owner
|
FYI: Working on the fixes over at #54 in case anybody wants to chime in. 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've ported CPython 3.6.5's test cases for json module to hyperjson. I disable the
test_recursion.pydue to it crash the process. Except thetest_recursion.py, I get44 failed, 27 passedfor these test cases. Hopefully, this can help us understand how compatable we are and disscover bugs or some edge cases.If we discover some behavior we won't implement at all, we better write them done to the docs.