player/loadfile: save watch later consistently on playlist manipulation#17226
player/loadfile: save watch later consistently on playlist manipulation#17226kasper93 wants to merge 1 commit intompv-player:masterfrom
Conversation
loadfile replace is not the only command that will change the current playing file and it is important to preserve watch later, when this happens.
|
This is subjective and therefore not really arguable, but if I zap through a playlisy, I certainly don't want each playlist item position to get saved when i skip manually to the next item. With a playlist, if I want to save the position, it would be only when I quit, so that next time I can continue from the same place. Again, subjective, but that's how I feel about it. |
The point is that replacing the current playlist can be considered as quitting, and therefore it triggers save-pos. This can be argued either way, but personally I think it's a reasonable analogy that replacing the current playlist is similar to quitting the current playlist. I personally can't see a general usefulness in saving pos of the current file when going to the next file manually. It might be useful to some, but I'd think that most users would find it anti-useful. The design of save-position-on-quit is to continue the next time when the current instance quits (and apparently also when it's replaced, like loadfile or loadlist). That means one logical save point per instance/playlist, not to save the position of each visited file when skipping to the next one. |
It doesn't.
The design of |
True, hence "logical". It's logically and originally the state of the instance/playlist when one quits - if one wants to resume this instance/playlist later from where they last quit. It did get extended over time to cover maybe other things too, and maybe it gained some inconsistencies along the way - like the fact that maybe not all playlist-replacements trigger save-pos when it's enabled, but still, essentially that is the overview and goal.
Not sure what you mean by that. From a user perspective, if this option is enabled and they quit, then next time they open the same file/playlist, it would resume from the last position. How is it not really "save position" or "on quit"? |
2 participants
loadfile replace is not the only command that will change the current playing file and it is important to preserve watch later, when this happens.