Add text wrapping to FreeText editors (issue 18191)#19345
Open
avdoseferovic wants to merge 1 commit intomozilla:masterfrom
Open
Add text wrapping to FreeText editors (issue 18191)#19345avdoseferovic wants to merge 1 commit intomozilla:masterfrom
avdoseferovic wants to merge 1 commit intomozilla:masterfrom
Conversation
Snuffleupagus
changed the title
Collaborator
Snuffleupagus
left a comment
Snuffleupagus
left a comment
There was a problem hiding this comment.
Please improve the commit message (see the commit history of the project for examples of how we usually write them):
- Note the updated PR title, which is thus also a good "title" for the commit message.
- Generally you want more than a single line in the commit message, such that relevant context is available also on the Git command line.
avdoseferovic
force-pushed
the
feat/add-text-wraping-to-freetext
branch
from
cbb1889 to
cd76eca
Compare
Contributor
|
/botio-linux preview |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/58c61e5873c6787/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/58c61e5873c6787/output.txt Total script time: 0.86 mins Published |
avdoseferovic
force-pushed
the
feat/add-text-wraping-to-freetext
branch
from
cd76eca to
0208f0b
Compare
Contributor
Author
|
@calixteman please do ignore this for now, my initial approach only worked when pages were not rotated. I tried extending it, but the resulting text after print/save is messed up |
avdoseferovic
changed the title
Text wrapping is ensured by preventing the FreeText editor from going out of bounds.
avdoseferovic
force-pushed
the
feat/add-text-wraping-to-freetext
branch
from
0208f0b to
a47cd37
Compare
avdoseferovic
changed the title
Contributor
Author
|
@calixteman this is now ready for review once again, I did a couple of tests with various rotations and zoom factors and all behaved well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm aware that there is already an PR open with the similar promise, but the implementation is different.
Note: please read the gist comments https://gist.github.com/bennadel/033e0158f47bff9e066016f99567ebba
This solution might face performance issues with very large text being added.
Fixes: #18191
Before
Screen.Recording.2025-01-18.at.23.24.58.mov
After
Screen.Recording.2025-01-18.at.23.26.22.mov