Add reviewer_status enum and fields#5704
Merged
suhaibmujahid merged 1 commit intomozilla:masterfrom Feb 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the Review Helper API by adding a ReviewerStatus enum and corresponding fields to track the specific status of reviewers (e.g., blocking, accepted, rejected). The changes refactor existing schemas to use a common base class that handles user action fields, and adds support for compound acting_capacity values that can encode both the capacity and reviewer status.
Changes:
- Added
ReviewerStatusenum with 8 status values (blocking, added, accepted, rejected, commented, accepted-older, rejected-older, resigned) - Created
UserActionBaseschema base class with validation logic foracting_capacityandreviewer_statusfields - Refactored
ReviewRequestCreateandFeedbackCreateschemas to inherit fromUserActionBase - Updated database models and routers to handle the new
reviewer_statusfield - Added Alembic migration to create the
reviewer_statusenum type and add columns toreview_requestsandfeedbacktables
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/reviewhelper-api/app/enums.py | Adds ReviewerStatus enum with 8 status values |
| services/reviewhelper-api/app/schemas/base.py | Creates UserActionBase with field extraction and validation logic |
| services/reviewhelper-api/app/schemas/review_request.py | Refactors ReviewRequestCreate to inherit from UserActionBase |
| services/reviewhelper-api/app/schemas/feedback.py | Refactors FeedbackCreate to inherit from UserActionBase |
| services/reviewhelper-api/app/database/models.py | Adds reviewer_status column to ReviewRequest and Feedback models |
| services/reviewhelper-api/app/routers/request.py | Passes reviewer_status when creating review requests |
| services/reviewhelper-api/app/routers/feedback.py | Passes reviewer_status when creating and updating feedback |
| services/reviewhelper-api/alembic/versions/b4e3f7a92c01_add_reviewer_status_column.py | Migration to add reviewer_status enum and columns (has critical filename bug) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
services/reviewhelper-api/alembic/versions/30a5eeb5f400_add_reviewer_status_column.py
Show resolved
Hide resolved
ccc8d45 to
cf84c83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #5684