Misc improvements part 7#5683
Merged
suhaibmujahid merged 2 commits intomozilla:masterfrom Feb 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates how external service configuration is sourced (Qdrant + Phabricator), aiming to simplify environment-based configuration and URL handling.
Changes:
- Qdrant client configuration switched from
get_secret(...)toos.getenv(...). - Phabricator client initialization refactored to derive an API URL from a base URL (
PHABRICATOR_URL) and removed reliance onPHABRICATOR_API_URL. - Phabricator URL-building logic consolidated into a cached
_base_url()helper and used in patch-related URLs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| bugbug/vectordb.py | Changes Qdrant connection configuration to use direct environment variables. |
| bugbug/tools/core/platforms/phabricator.py | Refactors Phabricator client/url configuration around a base URL and updates URL construction sites. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This makes it consistent with Bugzilla
suhaibmujahid
force-pushed
the
improvements-7
branch
from
830b4e8 to
e291160
Compare
marco-c
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
These improvements could be reviewed commit by commit.