Open
Conversation
Member
suhaibmujahid
left a comment
suhaibmujahid
left a comment
There was a problem hiding this comment.
Thank you, @olewicki! Please take a look at my comments.
bugbug/tools/code_review.py
Outdated
| return_only_outputs=True, | ||
| )["text"] | ||
|
|
||
| raw_output = self._get_comment_type(raw_output) |
Member
There was a problem hiding this comment.
I would move the process after running generate_processed_output(), then attach the types to the structured output instead of parsing the raw output twice.
bugbug/tools/code_review.py
Outdated
| "code_line": 458, | ||
| "comment" : "In the third code block, you are using `nsAutoStringN<256>` instead of `nsString`. This is a good change as `nsAutoStringN<256>` is more efficient for small strings. However, you should ensure that the size of `tempString` does not exceed 256 characters, as `nsAutoStringN<256>` has a fixed size." | ||
| "label": "Performance", | ||
| "label_justification": "Functional - Performance Optimization: Specific performance-focused refactoring." |
Member
There was a problem hiding this comment.
This seems like a subcategory, not a justification.
Co-authored-by: Suhaib Mujahid <smujahid@mozilla.com>
Co-authored-by: Suhaib Mujahid <smujahid@mozilla.com>
Co-authored-by: Suhaib Mujahid <smujahid@mozilla.com>
Co-authored-by: Suhaib Mujahid <smujahid@mozilla.com>
…end of the pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.