[component] Changed classification from Fenix::General to GeckoView::General#2588
Open
benjaminmah wants to merge 1 commit intomozilla:masterfrom
Open
[component] Changed classification from Fenix::General to GeckoView::General#2588benjaminmah wants to merge 1 commit intomozilla:masterfrom
benjaminmah wants to merge 1 commit intomozilla:masterfrom
Conversation
Comment on lines
-131
to
+134
| data["class"] = f"Fenix::{data['class']}" | ||
| if data["class"] == "General": | ||
| data["class"] = "GeckoView::General" | ||
| else: | ||
| data["class"] = f"Fenix::{data['class']}" |
Contributor
Author
There was a problem hiding this comment.
Based on the conversation with Marco here: mozilla/bugbug#4682 (comment), we can leave as it is. However, I was under the impression that we wanted the Fenix model to move bugs to GeckoView as well.
Contributor
Author
There was a problem hiding this comment.
@suhaibmujahid I was thinking we could just close this PR for now. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves mozilla/bugbug#4682.
When the Fenix component model returns
General, it ensures that it is classified asGeckoView::GeneralnotFenix::General.Checklist
to-be-announcedtag added if this is worth announcing