test: Updating older cross-build smoke tests (iOS, Android)#7487
Draft
thesuzerain wants to merge 15 commits into
Draft
test: Updating older cross-build smoke tests (iOS, Android)#7487thesuzerain wants to merge 15 commits into
thesuzerain wants to merge 15 commits into
Conversation
thesuzerain
commented
Jul 20, 2026
| MOZILLA_RUST_COMPONENTS_AS_PATH = "megazords/ios-rust/MozillaRustComponents.xcframework" | ||
|
|
||
|
|
||
| def replace_swift_package_artifact(ios_repo_path, as_repo_path): |
Collaborator
Author
There was a problem hiding this comment.
I don't love using regex here but given how often this artifact file is updated (with hashes, etc) it doesn't really seem possible to use a fixture for it.
thesuzerain
commented
Jul 20, 2026
jonesetc
reviewed
Jul 21, 2026
| # - xcode + xcodebuild + xcodetools setup and running (a successful build of the firefox-ios repository) | ||
| # Arguments: | ||
| # --action => Can be either `run-tests` (default) or `build-without-testing` | ||
| # --use-local-repo => Use a local firefox-ios repository instead (at the provided path). Exclusive with `remote-repo-url`. |
Member
There was a problem hiding this comment.
Looks outdated? There is a --firefox-dir FIREFOX_DIR, but no --use-local-repo or --remote-repo-url
jonesetc
reviewed
Jul 21, 2026
Member
|
Was able to force an android regression in testing with this patch: diff --git a/components/ads-client/src/lib.rs b/components/ads-client/src/lib.rs
index 2088ee16c..1279423e9 100644
--- a/components/ads-client/src/lib.rs
+++ b/components/ads-client/src/lib.rs
@@ -72,10 +72,10 @@ impl MozAdsClient {
#[uniffi::method(default(options = None))]
pub fn record_impression(
&self,
- impression_url: String,
+ impression_url_foo: String,
options: Option<MozAdsCallbackOptions>,
) -> AdsClientApiResult<()> {
- let url = AdsClientUrl::parse(&impression_url).map_err(|e| {
+ let url = AdsClientUrl::parse(&impression_url_foo).map_err(|e| {
ComponentError::RecordImpression(CallbackRequestError::InvalidUrl(e).into())
})?;
let ohttp = options.map(|o| o.ohttp).unwrap_or(false);and running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR bringing in smoke tests scripts for building application-services against various targets (Android and iOS here, HNT to come, see below). It deprecates some older similar tests that are very out of date, and remakes them with up-to-date building methods (and more test flexibility).
I used existing helpers from the existing smoke tests where possible.
See: build instructions for iOS and build instructions for Fenix for context about the steps.
This currently makes no breaking changes. It is also thought that the deprecated smoke tests have long fallen out of use.
Remaining work:
We want to build against HNT if possible as well, but currently, HNT doesn’t have a system for building against a local a-s like the other two do. There are a couple possibilities I've explored (eg: redirecting cargo paths) but none that have been trivial. As it may require non-test-script changes, I would propose we do that in another PR.
There is also a good amount of iOS and Android tests that fail naturally (seemingly even in clean unrelated builds), and most possible regressions in a-s don’t cause a build or test failure, so it may be prudent in the future to make to extend iOS/Android tests to cover a-s behaviour specifically now that we have these scripts.
Pull Request checklist
[ci full]to the PR title.