Add filter by webhook scanners in the scanner results Django admin#24374
Merged
willdurand merged 1 commit intomasterfrom Jan 30, 2026
Merged
Add filter by webhook scanners in the scanner results Django admin#24374willdurand merged 1 commit intomasterfrom
willdurand merged 1 commit intomasterfrom
Conversation
diox
requested changes
Jan 29, 2026
Member
diox
left a comment
diox
left a comment
There was a problem hiding this comment.
Please add a test around the list filtering logic (by scanner and by webhook scanner) - we typically don't bother doing that for django built-in filters, but since this one is now custom, we should ensure that it's tested.
willdurand
force-pushed
the
scanner-filter
branch
from
496fa10 to
631da04
Compare
diox
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#16008