refactor(funbox): wikipedia getTLD cleanup (@Eric-Zhang-Developer) #7401
+59
−225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehmer
reviewed
Jan 21, 2026
|
|
||
| case "euskera": | ||
| return "eu"; | ||
| const LANGUAGE_GROUP_TO_TLD: Partial<Record<LanguageGroupName, string>> = { |
Member
There was a problem hiding this comment.
- I think SCREAMING_SNAKE_CASE is not used widely in the codebase, maybe rename.
fehmer
reviewed
Jan 21, 2026
| default: | ||
| return "en"; | ||
| } | ||
| export function getTLD(languageGroup: LanguageGroupName): string { |
Member
There was a problem hiding this comment.
getTLD is not used anywhere, don't need to export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the
getTLDfunction inwikipedia.ts:async- The original function was markedasyncbut contained no asynchronous operations. It was just a pure synchronous string -> string mapping wrapped in a Promise for no reasonBefore: ~353 lines
After: ~187 lines
Net reduction: ~166 lines
No functional changes - same input/output behavior, just cleaner code.
Checks
qs,qsaorqsrinstead of JQuery selectors.packages/schemas/src/languages.tsfrontend/src/ts/constants/languages.tsfrontend/static/languagespackages/schemas/src/themes.tsfrontend/src/ts/constants/themes.tsfrontend/static/themespackages/schemas/src/layouts.tsfrontend/static/layoutsfrontend/static/webfontspackages/schemas/src/fonts.tsfrontend/src/ts/constants/fonts.ts