fix(profile): load user without personalBests (@fehmer) #7399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehmer
commented
Jan 21, 2026
Removed console log statement during user migration.
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
the
waiting for update
github-actions
bot
removed
the
waiting for update
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where users without the personalBests field in the database would cause problems when loaded through getUser or getUserByName. The fix introduces a migration function that ensures these users get an initialized personalBests structure.
Changes:
- Added
migrateUserhelper function to initialize missingpersonalBestsfields - Applied migration to
getUserandgetUserByNamefunctions - Added comprehensive test coverage for the migration behavior
- Reorganized imports alphabetically
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| backend/src/dal/user.ts | Added migrateUser function and applied it to user retrieval functions; reorganized imports |
| backend/tests/integration/dal/user.spec.ts | Added tests for missing personalBests scenarios; reorganized imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
removed
the
waiting for review
github-actions
bot
added
the
waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.