fix(devtools): guard invalid module info payloads#4787
Open
dmchoi77 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
🦋 Changeset detectedLatest commit: 466818a The changes in this PR will be included in the next version bump. This PR includes changesets to release 46 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a Chrome DevTools crash when Loading Trace is enabled and the Module Info tab is selected after refreshing the inspected page.
Invalid
moduleInfopayloads such as"[undefined]"can be relayed and stored aswindow.__FEDERATION__.moduleInfo, then later crash the Module Info renderer when it treats the value as a module snapshot.This change:
window.__FEDERATION__Verified with:
pnpm --filter @module-federation/devtools testpnpm exec turbo run build --filter=@module-federation/devtoolspnpm --filter @module-federation/devtools run build:devtoolNote:
pnpm exec turbo run lintwas attempted, but repo-wide lint currently fails in unrelatedapps/node-dynamic-remote-new-versionfiles due to existingrequire/moduleno-undeferrors. The changed DevTools package has no lint task.Related Issue
Fixes #4786
Types of changes
Checklist