fix: lazy load DTS plugin modules#4755
Draft
BleedingDev wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@module-federation/dts-pluginfrom the Rspack plugin only when DTS is enabled.@module-federation/dts-plugin/corefrom manifest metadata generation only when DTS metadata is needed.Why
Consumers that disable DTS should not need the DTS plugin packages to be resolved or imported at runtime. A plain nested
require()was not enough here because Rslib rewrote it into a top-level ESM import, so this usescreateRequire(import.meta.url)to keep both CJS and ESM outputs lazy.Validation
pnpm --filter @module-federation/manifest --filter @module-federation/rspack run lintpnpm exec jest --config packages/manifest/jest.config.js --runInBandpnpm exec jest --config packages/rspack/jest.config.js --runInBandpnpm --filter @module-federation/manifest... --filter @module-federation/rspack... run build