feat: support epoch-based checkpoint intervals - #9782
Open
tongchen126 wants to merge 1 commit into
Open
Conversation
Co-authored-by: andrewwchen <andrewwchen@tencent.com>
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
tongchen126
had a problem deploying
to
qoder-review
July 22, 2026 03:50 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Add the
--save_epochstraining argument for epoch-based checkpoint intervals.When set to a positive integer
N,save_epochsautomatically selects epoch-based checkpointing and saves at theend of epochs
N,2N, and so on. The option is supported by standard Transformers-based Swift training, nativeMegatron training, and Ray Megatron training. Epoch-based evaluation follows the same interval so that
load_best_model_at_endand best-checkpoint tracking remain consistent.The implementation validates that
save_epochs >= 1, converts epoch intervals to step intervals for Megatron and RayMegatron, and rejects streaming datasets in native Megatron and Ray Megatron when
save_epochsis requested becausetheir epoch length is unknown.
Existing
save_stepsandsave_strategybehavior remains unchanged whensave_epochsis not set. The training UI andEnglish/Chinese command-line documentation were updated accordingly.
Experiment results
git diff --checkpassed for all modified files.compatibility with existing Ray
save_strategy='epoch'configurations.dependency stack hung during
modelscopeimport; no test failure was reported.