Skip to content

fix(server): complete empty listen subscriptions - #2743

Open
SoulmatelynchVFX wants to merge 1 commit into
modelcontextprotocol:mainfrom
SoulmatelynchVFX:codex/fix-empty-subscriptions-listen
Open

fix(server): complete empty listen subscriptions#2743
SoulmatelynchVFX wants to merge 1 commit into
modelcontextprotocol:mainfrom
SoulmatelynchVFX:codex/fix-empty-subscriptions-listen

Conversation

@SoulmatelynchVFX

Copy link
Copy Markdown

Fixes #2650.\n\n## Summary\n- acknowledge and immediately complete subscriptions/listen when no requested notifications are honored\n- avoid creating a bus subscription or keep-alive timer for a stream that cannot deliver events\n- add a regression test for the empty-honored-filter lifecycle\n\n## Tests\n- �itest run test/server/createMcpHandlerListen.test.ts\n- Server typecheck\n- Prettier and ESLint for the changed source

@SoulmatelynchVFX
SoulmatelynchVFX requested a review from a team as a code owner September 1, 2026 10:51
@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3dd415e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2743

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2743

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2743

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2743

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2743

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2743

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2743

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2743

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2743

commit: 3dd415e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v2] subscriptions/listen holds a stream open even when it has honoured nothing

1 participant