fix: validate sampling/createMessage with correct schema #1387
+114
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Select the correct schema (
CreateMessageResultWithToolsSchemavsCreateMessageResultSchema) based on whethertoolswere provided in the request.Motivation and Context
Standard validation was incorrectly rejecting tool call arrays in sampling results because it was always using the non-tool schema. This allows clients to correctly receive tool use content from models.
How Has This Been Tested?
pnpm test:allto ensure no regressions.Types of changes
Checklist