fix: declare zod runtime dependencies#4289
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4288.
Summary
@modelcontextprotocol/server-sequential-thinkingimportszoddirectly from its runtime entrypoint, but the package did not declarezodas a dependency. With strict package isolation, consumers can install the server without a localzod, then hitERR_MODULE_NOT_FOUNDat runtime.While checking the same dependency boundary, I found two other published server packages with the same direct runtime import:
@modelcontextprotocol/server-memory@modelcontextprotocol/server-filesystemThis patch declares
zodin those three packages, using the same^4.0.0range already used by@modelcontextprotocol/server-everything.Validation
npm install --package-lock-only --ignore-scriptsnpm install --ignore-scriptsnpm run build --workspace=@modelcontextprotocol/server-sequential-thinkingnpm run build --workspace=@modelcontextprotocol/server-memorynpm run build --workspace=@modelcontextprotocol/server-filesystemnpm test --workspace=@modelcontextprotocol/server-sequential-thinkingnpm test --workspace=@modelcontextprotocol/server-memorynpm test --workspace=@modelcontextprotocol/server-filesystemnpm exec prettier -- --check src/filesystem/package.json src/memory/package.json src/sequentialthinking/package.json package-lock.jsongit diff --check