fix: preserve UNC path prefix in isPathWithinAllowedDirectories#3791
Open
hashwnath wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: preserve UNC path prefix in isPathWithinAllowedDirectories#3791hashwnath wants to merge 1 commit intomodelcontextprotocol:mainfrom
hashwnath wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3756
On Windows,
isPathWithinAllowedDirectoriesfails for UNC paths (e.g.\\server\share\project) becausepath.resolve(path.normalize(...))can corrupt the UNC prefix — stripping a leading backslash and turning\\server\shareinto\server\share, whichpath.resolvethen interprets as drive-relative (e.g.C:\server\share). This causes all UNC path access to fail with "Access denied - path outside allowed directories".Fix
Extract path normalization into a
normalizePath()helper that detects UNC paths and normalizes them withoutpath.resolve:\\server\share\...) are always absolute, sopath.normalizealone is sufficient\\prefix is preserved; restore it if strippedpath.resolve(path.normalize(...))as beforeTest plan
\\192.168.x.x\share), files within the share are now accessible