fix(publisher): accept UTF-8 BOM in server.json - #1528
Open
beeswaxpat wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, PowerShell 5.1's
Out-File -Encoding utf8(and several editors) write UTF-8 files with a leading byte order mark. Go'sencoding/jsondoes not skip the BOM, somcp-publisher publishandmcp-publisher validatefail on such server.json files with the cryptic errorinvalid character 'ï' looking for beginning of value. RFC 8259 section 8.1 says implementations may ignore a leading BOM, and we hit this in practice publishing a server from a Windows machine.This change strips a leading UTF-8 BOM (EF BB BF) from server.json bytes right after the file is read in both the publish and validate commands, using a small shared helper next to the existing UTF-8 validation in unicode.go. Both downstream request paths receive the cleaned bytes, so behavior is otherwise unchanged. Adds two tests that run a BOM-prefixed server.json through the full publish and validate paths.
🤖 Generated with Claude Code