fix: reject duplicate streamable HTTP initialize requests#969
Open
DragonFSKY wants to merge 1 commit into
Open
fix: reject duplicate streamable HTTP initialize requests#969DragonFSKY wants to merge 1 commit into
DragonFSKY wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initializerequests that include an activeMcp-Session-Idin the stateful Streamable HTTP transport.initializerequests without a session ID working as before.Fixes #962.
Testing
./mvnw -pl mcp-test -am -Dtest=HttpServletStreamableServerTransportProviderTests -Dsurefire.failIfNoSpecifiedTests=false test./mvnw -pl mcp-test -am -Dtest=HttpServletStreamableIntegrationTests,HttpServletStreamableServerTransportProviderTests -Dsurefire.failIfNoSpecifiedTests=false test./mvnw -pl mcp-test -am -Pjackson2 -Dtest=HttpServletStreamableServerTransportProviderTests -Dsurefire.failIfNoSpecifiedTests=false test./mvnw -pl mcp-core,mcp-test spring-javaformat:validategit diff --check