Allow the token to be refreshed without triggering a reauthentication#936
Open
guschnwg wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Allow the token to be refreshed without triggering a reauthentication#936guschnwg wants to merge 1 commit intomodelcontextprotocol:mainfrom
guschnwg wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Member
|
Thanks for working on this - token refresh is an important missing feature (#665). Apologies for the delay in reviewing; this has been open for a while and we appreciate your patience. The implementation works, but I have a suggestion that would make it cleaner: Consider using the client-side import { refreshAuthorization, discoverAuthorizationServerMetadata } from "@modelcontextprotocol/sdk/client/auth.js";
// Instead of ProxyOAuthServerProvider.exchangeRefreshToken(), use:
const newTokens = await refreshAuthorization(serverUrl, {
metadata: authServerMeta,
clientInformation: clientInfo,
refreshToken: authState.oauthTokens.refresh_token,
});Why?
This isn't blocking - the current approach works. But using the client function would be more aligned with the SDK's intended usage. Let me know if you'd like help with the refactor, or if there's a reason you chose This comment was drafted with assistance from Claude (AI). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When refreshing the token, it was triggering a reauthentication.
Since clients should use refresh tokens, when available, this feature is a good way to test that our MCP servers don't trigger unnecessary oauth flows.
Gravacao.de.Tela.2025-11-24.as.20.25.58.mov
Closes #665