mcp: improve http transports error handling and make transport work with any size message#734
Conversation
91f93af to
ee3d418
Compare
ee3d418 to
85a4340
Compare
|
@findleyr current proposal (no fixed buffer size) approach is inline with most sdks. Can we get this merged? |
|
@alexbumbacea sorry for the delay, will review tomorrow. |
85a4340 to
7ba1c9a
Compare
|
@findleyr all comments have been either replied to or addressed. are there any other concerns? |
3577e96 to
377a108
Compare
377a108 to
8f634ce
Compare
|
@findleyr is there anything else? |
8f634ce to
9fc710b
Compare
9fc710b to
9792dd9
Compare
|
@findleyr can we get this merged? |
|
@alexbumbacea very sorry, I thought I had merged this. Total oversight on my part. @maciej-kisiel we may want to cherry-pick this into the release, or do a second prerelease. |
|
Apologies again for this getting lost in the weeds: I think there are a few things that need to be addressed before merging. |
b434d37 to
da1ac52
Compare
da1ac52 to
d534f57
Compare
d534f57 to
0416a3a
Compare
0416a3a to
636995a
Compare
findleyr
left a comment
There was a problem hiding this comment.
It looks like my comments were addressed. However could you please also address @maciej-kisiel's before we merge?
Thanks for this change, this is a good cleanup.
Co-authored-by: Maciej Kisiel <macio92@gmail.com>
cfa78c5 to
3409d32
Compare
|
@findleyr @maciej-kisiel can we get this merged and included in a prerelease? Thanks! |
|
It looks good to me, I wanted to give @findleyr some time to take a look since there was a small change from the version he approved. But I think we can merge it and adjust as a follow-up if needed. With regard to the release, I think I would prefer to only include fixes to bugs that were introduced with a given pre-release. |
We have a use case for messages larger than 1MB, hence making this configurable would help.
In order to discover the source of our problems we had to spend some time investigating, as errors were silently discarded. So we also included changes to improving surfacing errors .