fix(e2e): make server-time element fill width for consistent mask #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add flex layout to .action p to make server-time stretch - Add #server-time flex: 1 rule across all basic-server variants - Update golden screenshots with full-width masked time field This ensures the Playwright mask covers a consistent width regardless of the timestamp content, fixing screenshot comparison flakiness.
jerome3o-anthropic
approved these changes
Jan 15, 2026
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-map
@modelcontextprotocol/server-pdf
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-shadertoy
@modelcontextprotocol/server-sheet-music
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-transcript
@modelcontextprotocol/server-video-resource
@modelcontextprotocol/server-wiki-explorer
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
#server-timeelement's width varied based on the timestamp content, causing Playwright's mask to have inconsistent dimensions across test runs, leading to screenshot comparison flakiness.Changes
CSS changes (across all 7 basic-server examples + integration-server):
display: flex; align-items: baseline; gap: 0.25em;to.action > pflex: 1; min-width: 0;to#server-timeGolden screenshots regenerated with Docker (linux) for platform-independent consistency.
Result
The mask now covers the full width after "Server Time:" regardless of the timestamp value, ensuring consistent screenshot comparisons.
Testing
All 72 E2E tests pass in Docker (matching CI environment).