fix: Check if cookies are iterable before iterating#356
fix: Check if cookies are iterable before iterating#356das-peter wants to merge 1 commit intominkphp:masterfrom
Conversation
It can happen that the returned value is not iterable. The geetAllCookies() methode also declares the its return as "mixed".
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
============================================
+ Coverage 90.02% 90.04% +0.02%
- Complexity 150 151 +1
============================================
Files 1 1
Lines 421 422 +1
============================================
+ Hits 379 380 +1
Misses 42 42
Continue to review full report at Codecov.
|
|
In which case does this happen ? |
|
I had a request to |
It can happen that the returned value is not iterable. The geetAllCookies() methode also declares the its return as "mixed".
Just about having slightly more defensive code.