Use container hostname + manager base URL instead of hardcoded IP in VS Code and SSH links#242
Closed
Use container hostname + manager base URL instead of hardcoded IP in VS Code and SSH links#242
Conversation
…Code and SSH links Co-authored-by: horner <6094599+horner@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix hardcoded IP addresses in links
Use container hostname + manager base URL instead of hardcoded IP in VS Code and SSH links
Mar 15, 2026
Member
|
@runleveldev please review. |
Collaborator
|
It's wrong to assume
I think (2) is the best option here. I'll open a different PR to handle it. |
Collaborator
|
Closing in preference of #243 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH links on the containers page used
site.externalIpas the host, producing raw-IP URLs (ssh://user@1.2.3.4:2222) that pollute VS Code and iTerm2 connection history with meaningless addresses.Changes
routers/containers.js— DerivesbaseUrlby stripping the first subdomain fromreq.hostname(e.g.manager.os.mieweb.org→os.mieweb.org), then computessshHost = {container.hostname}.{baseUrl}per row.sshHostis included in the row payload for both API and view responses.views/containers/index.ejs— Replacessite.externalIpwithr.sshHostin thevscode://andssh://linkhrefs; updates the render guard fromsite.externalIptor.sshHost.Result
The links now render as
{container}.{base_url}:{port}, giving meaningful names in connection history without requiring any additional configuration.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.