Skip to content

fix BatchRequestItem now properly serializes the header and body fields #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 5 commits into from
Jun 27, 2025
+31 −13
Merged

fix BatchRequestItem now properly serializes the header and body fields #959

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea3a24a
fix BatchRequestItem now properly serializes the header and body fields
carterm-hdc Jun 18, 2025
ad632ab
test Added a test for BatchRequestItem's serialize method.
carterm-hdc Jun 20, 2025
cf4fce6
test Serialize test for batch_request_item now uses the JsonSerializa…
carterm-hdc Jun 25, 2025
1436a6e
Merge branch 'main' into fix-batch-item-serialize
baywet Jun 27, 2025
f07b5b8
chore: formatting
baywet Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/msgraph_core/requests/batch_request_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,19 +258,16 @@ def serialize(self, writer: SerializationWriter) -> None:
writer.write_str_value('method', self.method)
writer.write_str_value('url', self.url)
writer.write_collection_of_primitive_values('depends_on', self._depends_on)
writer.write_collection_of_object_values(
'headers',
self._headers # type: ignore # need method to serialize dicts
writer.write_additional_data_value(
{'headers': self._headers} # need proper method to serialize dicts
Comment thread
baywet marked this conversation as resolved.
Outdated
)
if self._body:
json_object = json.loads(self._body)
is_json_string = json_object and isinstance(json_object, dict)
# /$batch API expects JSON object or base 64 encoded value for the body
if is_json_string:
writer.write_collection_of_object_values( # type: ignore
# need method to serialize dicts
'body',
json_object
writer.write_additional_data_value(
{'body': json_object} # need proper method to serialize dicts
Comment thread
baywet marked this conversation as resolved.
Outdated
)
else:
writer.write_str_value('body', base64.b64encode(self._body).decode('utf-8'))