Report DSC execution diagnostics on a timer#6196
Merged
JohnMcPMS merged 4 commits intomicrosoft:masterfrom May 7, 2026
Merged
Conversation
ProcessExecution already fired OutputLineReceived/ErrorLineReceived events per line as data arrived from the async stream readers, but RunSynchronously() never subscribed to them -- instead dumping all buffered output in one diagnostic message only after the process exited. If dsc.exe hangs, nothing appears in the log until (or unless) the process terminates. Add ProcessOutputBatcher, a thread-safe helper that: - Subscribes to ProcessExecution's stream events - Accumulates [out]/[err]-prefixed lines in a StringBuilder under a lock - Flushes the buffer to IDiagnosticsSink as a single batched message on a 500ms timer, so output appears promptly without one IPC call per line - Exposes Flush() to drain remaining lines after WaitForExit() Wire it into RunSynchronously(): the post-exit diagnostic now logs only the exit code (content has already been streamed). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
florelis
previously approved these changes
May 4, 2026
| this.buffer = new StringBuilder(); | ||
| } | ||
|
|
||
| this.sink.OnDiagnostics(DiagnosticLevel.Verbose, this.batchHeader + toEmit); |
Member
There was a problem hiding this comment.
Why do we need a batch header for every tick?
Member
Author
There was a problem hiding this comment.
Nothing guarantees that this is not intermingled with other diagnostics; the header contains the process number.
| foreach (string line in lines) | ||
| { | ||
| stringBuilder.AppendLine(line); | ||
| stringBuilder.Append(line).Append('\n'); |
Member
There was a problem hiding this comment.
Why not AppendLine() anymore? And why not Environment.NewLine?
Member
Author
There was a problem hiding this comment.
Because what ended up being in the log file was \r\r\n and VS Code was showing that as two lines. I did not attempt to find out exactly why that was happening.
… fix for the hang: default to redirecting input
florelis
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
To investigate why dsc appears to start hanging with 3.2.0, output dsc lines in batches on a timer rather than after the process has exited.
Microsoft Reviewers: Open in CodeFlow