Agent Host: enable session-specific Copilot sandbox settings - #335364
Draft
Dileep Yavanmandha (dileepyavan) wants to merge 4 commits into
Draft
Agent Host: enable session-specific Copilot sandbox settings#335364Dileep Yavanmandha (dileepyavan) wants to merge 4 commits into
Dileep Yavanmandha (dileepyavan) wants to merge 4 commits into
Conversation
Copilot started reviewing on behalf of
Dileep Yavanmandha (dileepyavan)
September 9, 2026 22:09
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The displayed defaults and managed-policy state can diverge from runtime behavior, and the linked issue’s required sandbox-specific confirmation remains unimplemented.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 4
New issues introduced by this change (4)
| Severity | Finding |
|---|---|
 |
src/vs/platform/agentHost/common/agentService.ts — This now reads chat.agent.sandbox.enabled even for the SDK shell path, while… |
|
src/vs/platform/agentHost/node/sessionPermissions.ts — The linked #333900 explicitly requires a sandbox-specific “Disable sandbox for this session and… |
|
src/vs/sessions/contrib/providers/copilotChatSessions/browser/permissionPicker.ts — This presentation uses the workbench-wide managed-settings snapshot, not the authoritative… |
|
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.ts — This editor picker also derives managed state from the workbench-wide snapshot rather than the… |
What changed in this PR
Adds session-scoped sandbox configuration for local Copilot Agent Host sessions, including persistence, policy enforcement, runtime updates, permissions UI, and tests.
Changes:
- Persists per-session sandbox choices with owner, restore, and fork semantics.
- Applies choices across SDK and custom-terminal execution under managed policy.
- Adds shared picker UI, bypass handling, tests, and documentation.
| File | Description |
|---|---|
src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/agentHostSandboxForwarder.test.ts |
Updates forwarding expectations. |
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/agentHostSandboxForwarder.ts |
Retains restrictions when disabled. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatInputPicker.test.ts |
Tests session toggle behavior. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.ts |
Adds editor session toggle. |
src/vs/sessions/contrib/providers/copilotChatSessions/test/browser/permissionPicker.test.ts |
Tests Agents-window toggle. |
src/vs/sessions/contrib/providers/copilotChatSessions/browser/permissionPicker.ts |
Integrates shared toggle UI. |
src/vs/sessions/contrib/providers/agentHost/test/browser/localAgentHostSessionsProvider.test.ts |
Verifies non-inheritance. |
src/vs/sessions/contrib/providers/agentHost/test/browser/agentHost/agentHostSessionConfigPicker.test.ts |
Verifies picker exclusion. |
src/vs/sessions/contrib/providers/agentHost/test/browser/agentHost/agentHostPermissionPickerDelegate.test.ts |
Tests per-session delegation. |
src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts |
Excludes sandbox from remembered defaults. |
src/vs/sessions/contrib/providers/agentHost/browser/agentHostSessionConfigPicker.ts |
Defers sandbox to permissions UI. |
src/vs/sessions/contrib/providers/agentHost/browser/agentHostPermissionPickerDelegate.ts |
Reads and writes session choices. |
src/vs/platform/agentHost/test/node/shared/editArcReporter.test.ts |
Updates configuration stub. |
src/vs/platform/agentHost/test/node/sessionSandbox.test.ts |
Covers ownership and policy precedence. |
src/vs/platform/agentHost/test/node/copilotShellTools.test.ts |
Tests custom-terminal updates. |
src/vs/platform/agentHost/test/node/copilotSessionLauncher.test.ts |
Tests startup policy handling. |
src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts |
Tests live SDK updates. |
src/vs/platform/agentHost/test/node/copilotAgent.test.ts |
Tests restore and fork semantics. |
src/vs/platform/agentHost/test/node/chatContributions.test.ts |
Tests metadata persistence. |
src/vs/platform/agentHost/test/node/agentHostChangesetOperationService.test.ts |
Updates configuration stub. |
src/vs/platform/agentHost/test/common/agentMetaReaders.test.ts |
Tests bypass metadata validation. |
src/vs/platform/agentHost/test/browser/agentHostSandboxToggle.test.ts |
Tests shared toggle logic. |
src/vs/platform/agentHost/node/sessionSandbox.ts |
Resolves session sandbox overrides. |
src/vs/platform/agentHost/node/sessionPermissions.ts |
Persists bypass opt-outs. |
src/vs/platform/agentHost/node/copilot/copilotShellTools.ts |
Associates engines with session URIs. |
src/vs/platform/agentHost/node/copilot/copilotSessionLauncher.ts |
Applies startup sandbox policy. |
src/vs/platform/agentHost/node/copilot/copilotSandboxPolicy.ts |
Projects runtime policy. |
src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts |
Applies live SDK configuration. |
src/vs/platform/agentHost/node/copilot/agentHostSandboxEngine.ts |
Merges session overrides. |
src/vs/platform/agentHost/node/agentConfigurationService.ts |
Stores runtime policy floors. |
src/vs/platform/agentHost/common/sessionConfigKeys.ts |
Defines persisted sandbox choice. |
src/vs/platform/agentHost/common/meta/agentToolCallMeta.ts |
Adds typed bypass metadata. |
src/vs/platform/agentHost/common/agentService.ts |
Selects sandbox default setting. |
src/vs/platform/agentHost/common/agentHostSchema.ts |
Advertises the session property. |
src/vs/platform/agentHost/browser/agentHostSandboxToggle.ts |
Shares toggle presentation logic. |
src/vs/platform/agentHost/AGENTS.md |
Documents sandbox architecture. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+287
to
+289
| export function getAgentHostCopilotSandboxSettingId(_customTerminalToolEnabled: boolean, windows = isWindows): AgentHostCopilotSandboxSettingId { | ||
| // TODO: Check Agent Host-specific sandbox settings once they are enabled for users. | ||
| return windows ? AgentSandboxSettingId.AgentSandboxWindowsEnabled : AgentSandboxSettingId.AgentSandboxEnabled; |
Comment on lines
490
to
+493
| /** | ||
| * Handles the side effect of a `ChatToolCallConfirmed` action when the | ||
| * user selected "Allow in this Session". Adds the tool to the session's | ||
| * permission allow list so future calls are auto-approved. | ||
| * user selected "Allow in this Session": persist a sandbox opt-out for | ||
| * escapes, or a tool permission for ordinary confirmations. |
Comment on lines
+488
to
+492
| provider: this._delegate.getSandboxToggleProvider?.(), | ||
| sessionEnabled: this._delegate.sandboxEnabled?.get(), | ||
| globalEnabled: settingId !== undefined && isAgentSandboxEnabledValue(this.configurationService.getValue<AgentSandboxEnabledSettingValue>(settingId)), | ||
| managedEnabled: this._delegate.managedSandboxEnforced?.get() === true, | ||
| allowsBypass: this.agentHostEnablementService.managedSandboxAllowsBypass.get(), |
Comment on lines
+777
to
+781
| provider: context?.backendSession.scheme, | ||
| sessionEnabled: value === AgentSandboxEnabledValue.On ? true : value === AgentSandboxEnabledValue.Off ? false : undefined, | ||
| globalEnabled: settingId !== undefined && isAgentSandboxEnabledValue(this._configurationService.getValue<AgentSandboxEnabledSettingValue>(settingId)), | ||
| managedEnabled: this._agentHostEnablementService.managedSandboxEnforced.get(), | ||
| allowsBypass: this._agentHostEnablementService.managedSandboxAllowsBypass.get(), |
Contributor
Screenshot ChangesBase: Changed (32)
|
| Before | After |
|---|---|
 |
 |
editor/inlineChatAffordance/InlineChatAffordance/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/HintsToolbar/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/HintsToolbar/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/HintsToolbarHovered/Dark
| Before | After |
|---|---|
|
|
editor/inlineCompletions/other/HintsToolbarHovered/Light
| Before | After |
|---|---|
|
|
editor/inlineCompletions/views/SideBySideViewSmall/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/SideBySideViewSmall/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/SideBySideViewWide/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/SideBySideViewWide/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/WordReplacementView/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/WordReplacementView/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/DeletionView/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/DeletionView/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/LineReplacementView/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/views/LineReplacementView/Light
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditor/Dark
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditor/Light
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorIncrementalPending/Dark
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorIncrementalPending/Light
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorIncrementalResolved/Dark
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorIncrementalResolved/Light
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorDocumentSwapAfter/Dark
| Before | After |
|---|---|
 |
 |
editor/multiDiffEditor/MultiDiffEditorDocumentSwapAfter/Light
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletions/Dark
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletions/Light
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletionsWithDetails/Dark
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletionsWithDetails/Light
| Before | After |
|---|---|
 |
 |
editor/multiDiff/multiDiffEditorScroll/RealWidget/Dark
| Before | After |
|---|---|
 |
 |
editor/multiDiff/multiDiffEditorScroll/RealWidget/Light
| Before | After |
|---|---|
 |
 |
peekReference/PeekReferences/Dark
| Before | After |
|---|---|
 |
 |
peekReference/PeekReferences/Light
| Before | After |
|---|---|
 |
 |
2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Errored (2)
Fixtures that failed to render — no screenshot was produced.
chat/input/chatInput/CopilotHarnessCompactPickers/Dark — [ComponentFixture] Dark virtual-time history (6 tasks):
Error: Cannot read properties of undefined (reading 'read')
TypeError: Cannot read properties of undefined (reading 'read')
at AutorunObserver._runFn (file:///home/runner/work/vscode/vscode/src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.ts:416:64)
at AutorunObserver._run (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:110:11)
at new AutorunObserver (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:58:8)
at autorun (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorun.ts:20:9)
at new AgentHostChatInputPicker (file:///home/runner/work/vscode/vscode/src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.ts:414:25)
at TestInstantiationService._createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:162:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:128:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts:62:16)
at createPicker (file:///home/runner/work/vscode/vscode/src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts:3902:59)
at provider (file:///home/runner/work/vscode/vscode/src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts:3908:64)
at Object.actionViewItemProvider (file:///home/runner/work/vscode/vscode/src/vs/platform/actions/browser/toolbar.ts:369:22)
at Object.actionViewItemProvider (file:///home/runner/work/vscode/vscode/src/vs/base/browser/ui/toolbar/toolbar.ts:152:29)
at file:///home/runner/work/vscode/vscode/src/vs/base/browser/ui/actionbar/actionbar.ts:365:25
at Array.forEach (<anonymous>)
at ActionBar.push (file:///home/runner/work/vscode/vscode/src/vs/base/browser/ui/actionbar/actionbar.ts:356:11)
at file:///home/runner/work/vscode/vscode/src/vs/base/browser/ui/toolbar/toolbar.ts:322:19
at Array.forEach (<anonymous>)
at MenuWorkbenchToolBar.setActions (file:///home/runner/work/vscode/vscode/src/vs/base/browser/ui/toolbar/toolbar.ts:321:23)
at MenuWorkbenchToolBar.setActions (file:///home/runner/work/vscode/vscode/src/vs/platform/actions/browser/toolbar.ts:195:9)
at MenuWorkbenchToolBar._updateToolbar (file:///home/runner/work/vscode/vscode/src/vs/platform/actions/browser/toolbar.ts:405:9)
at new MenuWorkbenchToolBar (file:///home/runner/work/vscode/vscode/src/vs/platform/actions/browser/toolbar.ts:394:8)
at TestInstantiationService._createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:162:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:128:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts:62:16)
at ChatInputPart.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts:3794:68)
at renderChatInput (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/chat/renderChatInput.ts:252:12)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/chat/chatInput.fixture.ts:132:37)
at actualRender (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1175:29)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1209:4)
at Eo.waitForRendering (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:3600:1)
at gs.renderFixture (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:6819:1)
at async <anonymous>:329:30
at Object.run (file:///home/runner/work/vscode/vscode/src/vs/base/common/errors.ts:30:12)
at VirtualClock.runNext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/virtualClock.ts:86:6)
at fn (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:262:28)
at TraceContext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/trace.ts:156:11)
at VirtualTimeProcessor._executeOne (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:259:4)
at VirtualTimeProcessor._step (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:253:8)
at Object.VirtualTimeProcessor._drive [as callback] (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:290:26)
at file:///home/runner/work/vscode/vscode/src/vs/base/common/platform.ts:235:17
chat/input/chatInput/CopilotHarnessCompactPickers/Light — [ComponentFixture] Light virtual-time history (6 tasks):
Error: Cannot read properties of undefined (reading 'read')
TypeError: Cannot read properties of undefined (reading 'read')
at AutorunObserver._runFn (file:///home/runner/work/vscode/vscode/src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.ts:416:64)
at AutorunObserver._run (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:110:11)
at new AutorunObserver (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorunImpl.ts:58:8)
at autorun (file:///home/runner/work/vscode/vscode/src/vs/base/common/observableInternal/reactions/autorun.ts:20:9)
at new AgentHostChatInputPicker (file:///home/runner/work/vscode/vscode/src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.ts:414:25)
at TestInstantiationService._createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:162:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:128:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts:62:16)
at createPicker (file:///home/runner/work/vscode/vscode/src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts:3902:59)
at provider (file:///home/runner/work/vscode/vscode/src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts:3908:64)
at Object.actionViewItemProvider (file:///home/runner/work/vscode/vscode/src/vs/platform/actions/browser/toolbar.ts:369:22)
at Object.actionViewItemProvider (file:///home/runner/work/vscode/vscode/src/vs/base/browser/ui/toolbar/toolbar.ts:152:29)
at file:///home/runner/work/vscode/vscode/src/vs/base/browser/ui/actionbar/actionbar.ts:365:25
at Array.forEach (<anonymous>)
at ActionBar.push (file:///home/runner/work/vscode/vscode/src/vs/base/browser/ui/actionbar/actionbar.ts:356:11)
at file:///home/runner/work/vscode/vscode/src/vs/base/browser/ui/toolbar/toolbar.ts:322:19
at Array.forEach (<anonymous>)
at MenuWorkbenchToolBar.setActions (file:///home/runner/work/vscode/vscode/src/vs/base/browser/ui/toolbar/toolbar.ts:321:23)
at MenuWorkbenchToolBar.setActions (file:///home/runner/work/vscode/vscode/src/vs/platform/actions/browser/toolbar.ts:195:9)
at MenuWorkbenchToolBar._updateToolbar (file:///home/runner/work/vscode/vscode/src/vs/platform/actions/browser/toolbar.ts:405:9)
at new MenuWorkbenchToolBar (file:///home/runner/work/vscode/vscode/src/vs/platform/actions/browser/toolbar.ts:394:8)
at TestInstantiationService._createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:162:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/common/instantiationService.ts:128:18)
at TestInstantiationService.createInstance (file:///home/runner/work/vscode/vscode/src/vs/platform/instantiation/test/common/instantiationServiceMock.ts:62:16)
at ChatInputPart.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts:3794:68)
at renderChatInput (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/chat/renderChatInput.ts:252:12)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/chat/chatInput.fixture.ts:132:37)
at actualRender (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1175:29)
at Object.render (file:///home/runner/work/vscode/vscode/src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts:1209:4)
at Eo.waitForRendering (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:3600:1)
at gs.renderFixture (file:///home/runner/work/vscode/vscode/build/rspack/node_modules/@vscode/component-explorer/dist/viewer.js:6819:1)
at async <anonymous>:329:30
at Object.run (file:///home/runner/work/vscode/vscode/src/vs/base/common/errors.ts:30:12)
at VirtualClock.runNext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/virtualClock.ts:86:6)
at fn (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:262:28)
at TraceContext (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/trace.ts:156:11)
at VirtualTimeProcessor._executeOne (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:259:4)
at VirtualTimeProcessor._step (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:253:8)
at Object.VirtualTimeProcessor._drive [as callback] (file:///home/runner/work/vscode/vscode/src/vs/base/test/common/virtualScheduling/processor.ts:290:26)
at file:///home/runner/work/vscode/vscode/src/vs/base/common/platform.ts:235:17
blocks-ci screenshots changed
Replace the contents of test/componentFixtures/blocks-ci-screenshots.md with:
Updated blocks-ci-screenshots.md
<!-- auto-generated by CI — do not edit manually -->
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentHostPromptMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentHostPromptMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/CodexSkillMissingDescriptionHover/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/CodexSkillMissingDescriptionHover/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/ConfiguredLocationsMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/ConfiguredLocationsMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUninstalled/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUninstalled/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetailNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetailNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/SessionsCodexSkillMissingDescriptionHover/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/SessionsCodexSkillMissingDescriptionHover/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/UserDataMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/UserDataMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePage/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePage/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllAccessoriesFacing/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllAccessoriesFacing/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllRuntimeStates/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllRuntimeStates/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CoveredAntennaeComparison/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CoveredAntennaeComparison/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CriticalPoses/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CriticalPoses/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/LiveEyeLayering/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/LiveEyeLayering/Light
#### chat/chatQuestionCarousel/MarkdownLinks/Dark
#### chat/chatQuestionCarousel/MarkdownLinks/DarkHighContrast
#### chat/chatQuestionCarousel/MarkdownLinks/Light
#### chat/chatQuestionCarousel/MarkdownLinks/LightHighContrast
#### chat/input/chatInput/CompactWithProviderIcon/Dark
#### chat/input/chatInput/CompactWithProviderIcon/Light
#### chat/input/chatInput/CopilotHarnessCompactPickers/Dark
#### chat/input/chatInput/CopilotHarnessCompactPickers/Light
#### chat/petAchievements/standaloneModal/chatPetAchievementsEditor/MixedSelected/Dark
#### chat/petAchievements/standaloneModal/chatPetAchievementsEditor/MixedSelected/Light
#### editor/codeEditor/CodeEditor/Dark
#### editor/codeEditor/CodeEditor/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthClassification/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthClassification/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthCode/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthCode/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthFont/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthFont/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthProportionalFont/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthProportionalFont/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthSelection/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthSelection/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthTwoCells/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthTwoCells/Light
#### editor/injectedTextDecorations/ColorDecorators/Dark
#### editor/injectedTextDecorations/ColorDecorators/Light
#### editor/injectedTextDecorations/InlayHints/Dark
#### editor/injectedTextDecorations/InlayHints/Light
#### editor/injectedTextDecorations/InlineProgress/Dark
#### editor/injectedTextDecorations/InlineProgress/Light
#### editor/injectedTextDecorations/SelectedColorDecorator/Dark
#### editor/injectedTextDecorations/SelectedColorDecorator/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Light
#### sessions/accountMenu/petAchievementBadges/chatPetAchievementBadges/AllBadges/Dark
#### sessions/accountMenu/petAchievementBadges/chatPetAchievementBadges/AllBadges/Light
#### sessions/chat/input/chatInput/ResponsiveModelResizeCycleMinimal/Dark
#### sessions/chat/input/chatInput/ResponsiveModelResizeCycleMinimal/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionAutoModel/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionAutoModel/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionChatBackground/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionChatBackground/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionCompactAutoModel/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionCompactAutoModel/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionPhoneAttachedContext/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionPhoneAttachedContext/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Light
#### sessions/chat/view/chatView/AssistantResponseBackground/Dark
#### sessions/chat/view/chatView/AssistantResponseBackground/Light
#### sessions/chat/view/chatView/AssistantResponsePlain/Dark
#### sessions/chat/view/chatView/AssistantResponsePlain/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/Light
#### sessions/sessionsList/SessionsList_LightweightNewButton/Dark
#### sessions/sessionsList/SessionsList_LightweightNewButton/DarkHighContrast
#### sessions/sessionsList/SessionsList_LightweightNewButton/Light
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/Dark
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/DarkHighContrast
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/Light
#### sessions/sessionsList/SessionsList_NarrowHoverToolbar/Dark
#### sessions/sessionsList/SessionsList_NarrowHoverToolbar/Light
#### sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Dark
#### sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Light
#### sessions/sessionsList/SessionsList_PeerChatInProgress/Dark
#### sessions/sessionsList/SessionsList_PeerChatInProgress/Light
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/Dark
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/DarkHighContrast
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/Light
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/Dark
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/DarkHighContrast
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/Light
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/Dark
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/DarkHighContrast
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/Light
Patch
--- test/componentFixtures/blocks-ci-screenshots.md 2026-09-10 03:01:50.423722853 +0000
+++ /tmp/blocks-ci-updated.md 2026-09-10 03:13:20.142156884 +0000
@@ -175,10 +175,10 @@
#### chat/input/chatInput/CopilotHarnessCompactPickers/Dark
-
+
#### chat/input/chatInput/CopilotHarnessCompactPickers/Light
-
+
#### chat/petAchievements/standaloneModal/chatPetAchievementsEditor/MixedSelected/Dark
Dileep Yavanmandha (dileepyavan)
marked this pull request as ready for review
September 10, 2026 03:00
Dileep Yavanmandha (dileepyavan)
marked this pull request as draft
September 10, 2026 03:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #333900.
Adds a persisted, session-scoped sandbox choice for the local Copilot Agent Host, without changing the user's global sandbox settings. This control is not added to Claude, Codex, or extension-backed Copilot Chat.
Changes
sandboxEnabled(default,on,off) to session configuration. Missing/defaultfollows current global settings; explicit choices survive restore. Peer chats and nested subagents resolve to the same owner. New sessions and forks do not inherit the choice.Review Guide
sessionConfigKeys.ts,agentHostSchema.ts,agentConfigurationService.ts, andsessionSandbox.ts: persisted choice, owner resolution, and precedence.copilotSandboxPolicy.ts,copilotSessionLauncher.ts,copilotAgentSession.ts,agentHostSandboxEngine.ts, andsessionPermissions.ts: runtime application and escape handling.agentHostSandboxToggle.ts, picker/delegate changes, andagentHostSandboxForwarder.ts: presentation, session writes, and global defaults.src/vs/platform/agentHost/AGENTS.md.Validation
origin/mainat585a254fad3in signed commit229facda6b8. No unresolved conflicts; stagedgit diff --checkpassed. Merge pre-commit hygiene passed for 349 eligible files from 455 staged files.autoTierandclientInfooptions, plus an apparently stale test-stub diagnostic (the reported missing methods are present). Dependency/typecheck reconciliation remains pending.gulp hygieneis blocked locally by an existing Windows path construction error (C:\C:\...); standalone changed-file hygiene and both signed commits' pre-commit hooks passed.Manual Verification / Draft Follow-ups
Live UI/SDK end-to-end verification is still pending. Picker dismissal after toggling remains unverified, and changed toggle presentations still use whole-list refreshes. The sandbox-specific confirmation wording requested in #333900 remains a follow-up.