Add an Agent Inbox catch-up action - #335344
Draft
Megan Rogge (meganrogge) wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9600876a-8143-4338-b588-d956e3ada89b
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 9, 2026 19:58
View session
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9600876a-8143-4338-b588-d956e3ada89b
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/sessions/browser/sessionsCatchUp.ts — The new action's accept path is not covered by a focused test: normal open, background accept, and… |
What changed in this PR
Adds an AI-gated Agent Inbox quick-pick action for triaging sessions.
Changes:
- Groups sessions by attention priority and status.
- Reuses shared session quick-pick presentation.
- Adds menu registration and grouping tests.
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/test/browser/sessionsCatchUp.test.ts | Updated as part of this pull request. |
| src/vs/sessions/contrib/sessions/browser/sessionsPicker.ts | Updated as part of this pull request. |
| src/vs/sessions/contrib/sessions/browser/sessionsCatchUp.ts | Updated as part of this pull request. |
| src/vs/sessions/contrib/sessions/browser/sessionsActions.ts | Updated as part of this pull request. |
| src/vs/sessions/contrib/sessions/browser/sessions.contribution.ts | Updated as part of this pull request. |
Suppressed comments (2)
src/vs/sessions/contrib/sessions/browser/sessionsCatchUp.ts:165
- The modifier/background opening path is duplicated from
sessionsActions.ts(openSelected). Please extract the shared operation and use it from both pickers; otherwise a later change to side placement, activation, orpreserveFocuscan make the two session pickers behave differently.
return;
}
const toSide = picker.keyMods.ctrlCmd || picker.keyMods.alt;
if (toSide && activeSessionId !== undefined && selected.session.sessionId !== activeSessionId) {
sessionsService.insertAt(selected.session, activeSessionId, 'right', !event.inBackground);
src/vs/sessions/contrib/sessions/browser/sessionsCatchUp.ts:163
- The side-open branch bypasses the SessionsService open lifecycle by calling
insertAtdirectly. UnlikeopenSession/openSessionToSide, this does not resolve superseded resources or run providerprepareSessionForOpen(and can also leave a custom view mounted), so modifier-opening a legacy or not-yet-prepared session can mount the wrong/uninitialized facade. Please add/use an anchored side-open path that performs the normal resolution and preparation before inserting beside the active session.
const toSide = picker.keyMods.ctrlCmd || picker.keyMods.alt;
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+156
to
+165
| disposables.add(picker.onDidAccept(event => { | ||
| const selected = picker.selectedItems[0]; | ||
| if (!selected || selected.kind !== 'session') { | ||
| return; | ||
| } | ||
| const toSide = picker.keyMods.ctrlCmd || picker.keyMods.alt; | ||
| if (toSide && activeSessionId !== undefined && selected.session.sessionId !== activeSessionId) { | ||
| sessionsService.insertAt(selected.session, activeSessionId, 'right', !event.inBackground); | ||
| } else { | ||
| void sessionsService.openSession(selected.session.resource, { preserveFocus: event.inBackground, source: 'sessionsList' }).catch(onUnexpectedError); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a focused Catch Up on Agents action to the Agents window so users can quickly triage work across sessions.
The Agent Inbox prioritizes:
Selecting a result opens that session, while modifier-click behavior can open it to the side. The action reuses the existing provider-neutral session model, blocked-session CI detection, status icons, and quick-pick presentation. It is hidden when AI features are disabled.
Validation
npm run typecheck-clientnpm run valid-layers-checkgit diff --check