sessions: fix endless spinner in Changes view for non-git folders

[Sparsh :) (SparshGarg999)]

This PR fixes GitHub issue #324066: endless loading spinner in the Changes view when opening non-git directories.

Root Cause Analysis

For non-git workspaces or non-git folders, activeSessionHasGitRepositoryObs in ChangesViewService evaluates to false. When there's no Git repository, the changeset's isLoadingChanges can remain stuck in a loading state if it tries to resolve refs via Git. Specifically, in UncommittedChangesChangeset and other git-backed changesets, isLoadingChanges evaluates to true whenever the changeset resolver returns undefined.

In GitRepositoryChangesetResolver.resolve(...), if repositoryUri is not present, it returns undefined. Because it returns undefined, changesPromiseObs.read(reader).read(reader) remains undefined, which keeps the changeset's isLoadingChanges stuck as true indefinitely. This propagates up to the UI, leading to an endless spinner.

Fix

Modify GitRepositoryChangesetResolver.resolve(...) to return an empty array [] instead of undefined when the repository is not available. This signals to the changeset state observable that the resolution has completed (yielding no changes) rather than indicating that it is still loading.

[Copilot]

Pull request overview

This PR fixes issue #324066, where the Changes view showed an endless loading spinner when a session's workspace folder is not a git repository. The root cause is that GitRepositoryChangesetResolver.resolve(...) returned undefined when no repository URI was available, and the downstream changeset observables interpret an undefined resolved value as "still loading", which never clears. The fix returns an empty array instead, signaling a completed resolution with no changes.

Changes:

• In GitRepositoryChangesetResolver.resolve(...), return [] instead of undefined when there is no repository URI, so isLoadingChanges resolves to false for non-git folders.

[Copilot]

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0 new
• Review effort level: Medium