Remove the system-wide keybindings first-run dialog

[ulugbekna]

Follow-up to #323871.

Why

We got feedback that the first-run notice for system-wide keybindings can pop up in more than one window at the same time on startup. The feature had a main-process "elect one window" mechanism meant to prevent that, but it was racy across renderers that sync concurrently, so the notice still leaked into multiple windows.

Rather than harden the election, we're removing the dialog entirely. The feature is always on, and a user who marks a keybinding "systemWide": true in keybindings.json already knows what they are doing, so a one-time notice adds little.

What

Deletes the whole notice path, which only existed to serve that dialog:

• Renderer (systemWideKeybindings.contribution.ts): drops the first-run notification, the acknowledged-storage gate, and the IDialogService/IStorageService dependencies. sync() now just warns about ignored when clauses and pushes bindings to the main process.
• Main process (globalKeybindingsMainService.ts, nativeHostMainService.ts): drops the elected-window bookkeeping, so INativeSystemWideKeybindingResult reports only registration failures.
• Schema / tests: updates the systemWide description in the keybindings.json schema and removes the now-obsolete election unit tests.

Global registration and trigger routing are unchanged.

Notes for reviewers

The diff is a net removal (+17 / -63 across 5 files). It builds on an unmerged follow-up that had added the election machinery, so the squashed change relative to main cleanly deletes the dialog without leaving native.ts or the test service mock touched.

How to test

1. Add a systemWide keybinding to keybindings.json, e.g. { "key": "ctrl+cmd+a", "command": "workbench.action.openAgentsWindow", "systemWide": true }.
2. Restart with multiple windows open and confirm no first-run dialog appears in any window.
3. Confirm the keybinding still registers and triggers the command system-wide.

[Copilot]

Pull request overview

Removes the first-run “system-wide keybindings” notice path to avoid racy multi-window startup behavior, keeping the underlying global shortcut registration/routing intact while simplifying the renderer↔main-process sync contract.

Changes:

• Drops the renderer-side first-run dialog, storage gating, and related service dependencies; sync now only warns about ignored when clauses and pushes keybindings to the main process.
• Simplifies main-process sync results to report only registration failures via INativeSystemWideKeybindingResult.
• Updates schema text and adapts unit tests to the updated return shape.

Show a summary per file

File	Description
src/vs/workbench/services/keybinding/browser/keybindingService.ts	Updates the systemWide schema description to remove the first-run notice wording.
src/vs/workbench/contrib/keybindings/electron-browser/systemWideKeybindings.contribution.ts	Removes the first-run dialog/storage gate and leaves only warning + sync behavior.
src/vs/platform/native/electron-main/nativeHostMainService.ts	Returns the main-service result directly from syncSystemWideKeybindings (failures only).
src/vs/platform/globalKeybindings/test/electron-main/globalKeybindingsMainService.test.ts	Updates tests to destructure { failed } from the new result shape.
src/vs/platform/globalKeybindings/electron-main/globalKeybindingsMainService.ts	Changes updateKeybindings to return INativeSystemWideKeybindingResult instead of a raw string array.

Review details

• Files reviewed: 5/5 changed files
• Comments generated: 0
• Review effort level: Low