sessions: align aquarium corners with chat panel#315351
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the Agents window “aquarium” water overlay clipping with the Chat Bar card surface so the decorative layer matches the panel’s rounded corners, and documents that relationship in the sessions layout spec.
Changes:
- Update the aquarium water layer styling to inherit its parent (Chat Bar) border radius instead of using a hardcoded value.
- Document the aquarium water layer’s clipping relationship in
LAYOUT.md. - Add a revision-history entry describing the change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/sessions/LAYOUT.md | Documents the aquarium water layer mounting/clipping behavior and records the change in revision history. |
| src/vs/sessions/contrib/aquarium/browser/media/aquarium.css | Switches the water layer to border-radius: inherit so its clipping follows the Chat Bar card radius. |
eleanorjboyd
approved these changes
May 8, 2026
…m-easter-egg-corners Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #315037
Before:
After:
Validation
npm run precommitpassednpm run compile-check-ts-nativeandnpm run valid-layers-checkare currently blocked by an existing unrelated error insrc/vs/workbench/contrib/chat/browser/widget/input/chatInputNotificationService.ts:177wherestring | IMarkdownStringis passed tostatus(string)