chore: update @github/copilot to 1.0.43#314912
Open
DonJayamanne wants to merge 1 commit intomainfrom
Open
Conversation
…lated file references Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Errored (20)Fixtures that failed to render — no screenshot was produced.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Copilot Chat extension’s bundled @github/copilot SDK to ^1.0.43, aligning postinstall packaging and upgrade tests with the SDK’s updated native-binary layout.
Changes:
- Bump
@github/copilotdependency from^1.0.39to^1.0.43(and lockfile updates). - Adjust
postinstall.tsto copywin32_native.dllinstead of the previouswin32.nodehelper. - Update the SDK upgrade test inventory/exclusions and reintroduce the node-pty shim setup before SDK load.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/chatSessions/copilotcli/vscode-node/test/copilotCLISDKUpgrade.spec.ts | Updates binary allowlist for the new SDK layout and changes shim/test setup around SDK loading. |
| extensions/copilot/script/postinstall.ts | Updates prebuild copy filter to match renamed Windows helper (win32_native.dll). |
| extensions/copilot/package.json | Bumps @github/copilot dependency to ^1.0.43. |
| extensions/copilot/package-lock.json | Locks @github/copilot (and platform packages) to 1.0.43. |
Copilot's findings
Files not reviewed (1)
- extensions/copilot/package-lock.json: Language not supported
- Files reviewed: 3/4 changed files
- Comments generated: 1
Comment on lines
+166
to
+168
| const nodePtyShimFileNames = new Set(['pty.node', 'spawn-helper']); | ||
| const isNodePtyShimFile = (binary: string) => | ||
| binary.startsWith(nodePtyShimDir + path.sep) && nodePtyShimFileNames.has(path.basename(binary)); |
aeschli
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the
@github/copilotnpm package in the Copilot Chat extension from^1.0.39to^1.0.43.Changes
package.json/package-lock.json@github/copilotdependency to^1.0.43.script/postinstall.tscopyCopilotCliPrebuildFilesfilter fromwin32.node→win32_native.dll(the SDK renamed this helper in 1.0.43).copilotCLISDKUpgrade.spec.tscopyNodePtyFilesshim setup inbeforeAll— 1.0.43's bundledloadNativeModulenow looks forpty.noderelative to the SDK folder so the shim must be applied before the SDK is loaded (same as the production code path).win32.node→win32_native.dllpty.node/spawn-helperfiles so they don't trigger the "unexpected binary" check.Notes
src/required changes. The chat extension imports only type aliases from the SDK that remained shape-compatible.